Changeset 247330 in webkit
- Timestamp:
- Jul 10, 2019 3:42:21 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r247327 r247330 1 2019-07-10 Chris Fleizach <cfleizach@apple.com> 2 3 AX: VoiceOver ignored role="presentation" on <table> HTML elements 4 https://bugs.webkit.org/show_bug.cgi?id=199659 5 6 Reviewed by Zalan Bujtas. 7 8 * accessibility/ios-simulator/tables-lists-expected.txt: 9 * accessibility/ios-simulator/tables-lists.html: 10 1 11 2019-07-10 Ryosuke Niwa <rniwa@webkit.org> 2 12 -
trunk/LayoutTests/accessibility/ios-simulator/tables-lists-expected.txt
r187904 r247330 3 3 table item 1 table item 2 table item 3 4 4 landmark 1 5 table item 1 5 6 This test makes sure that items in lists, tables and landmarks have different traits on them, because they're contained in different items. 6 7 … … 14 15 PASS tableItem.traits != landmarkItem.traits is true 15 16 PASS landmarkItem.traits != initialItem.traits is true 17 PASS nonTableItem.traits != tableItem.traits is true 16 18 PASS successfullyParsed is true 17 19 -
trunk/LayoutTests/accessibility/ios-simulator/tables-lists.html
r187904 r247330 27 27 </div> 28 28 29 <table border=1 role="presentation"> 30 <tr role="presentation"><td role="presentation">table item 1</td></tr> 31 </table> 32 29 33 </div> 30 34 … … 44 48 var tableItem = root.childAtIndex(2).childAtIndex(0); 45 49 var landmarkItem = root.childAtIndex(3).childAtIndex(0); 50 var nonTableItem = root.childAtIndex(4); 46 51 47 52 shouldBe("listItem.traits != initialItem.traits", "true"); … … 53 58 54 59 shouldBe("landmarkItem.traits != initialItem.traits", "true"); 60 61 shouldBe("nonTableItem.traits != tableItem.traits", "true"); 55 62 } 56 63 -
trunk/Source/WebCore/ChangeLog
r247329 r247330 1 2019-07-10 Chris Fleizach <cfleizach@apple.com> 2 3 AX: VoiceOver ignored role="presentation" on <table> HTML elements 4 https://bugs.webkit.org/show_bug.cgi?id=199659 5 6 Reviewed by Zalan Bujtas. 7 8 Only include a table ancestor if it's a table we care about for accessibility. 9 10 Modified Test: accessibility/ios-simulator/tables-lists.html 11 12 * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm: 13 (-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]): 14 1 15 2019-07-10 Robin Morisset <rmorisset@apple.com> 2 16 -
trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm
r247071 r247330 593 593 - (AccessibilityObjectWrapper*)_accessibilityTableAncestor 594 594 { 595 596 595 if (const AccessibilityObject* parent = AccessibilityObject::matchedParent(*m_object, false, [] (const AccessibilityObject& object) { 597 return object. isTable();596 return object.roleValue() == AccessibilityRole::Table; 598 597 })) 599 598 return parent->wrapper();
Note: See TracChangeset
for help on using the changeset viewer.