Changeset 247384 in webkit

Timestamp:

Jul 12, 2019 3:08:57 AM (5 years ago)

Author:

Adrian Perez de Castro

Message:

[ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
​https://bugs.webkit.org/show_bug.cgi?id=199748
<rdar://problem/52995908>

Reviewed by Konstantin Tokarev.

No new tests needed.

• accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(listObjectForCoreSelection): Renamed from listObjectForSelection() and remove the
unneeded call to core() now that coreSelection is passed directly to the function.
(optionFromList): Change to pass coreSelection directly to listObjectForCoreSelection().

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/atk/WebKitAccessibleInterfaceSelection.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-12  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [ATK] Avoid unneeded call to to core(selection) in listObjectForSelection()
+        https://bugs.webkit.org/show_bug.cgi?id=199748
+        <rdar://problem/52995908>
+
+        Reviewed by Konstantin Tokarev.
+
+        No new tests needed.
+
+        * accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:
+        (listObjectForCoreSelection): Renamed from listObjectForSelection() and remove the
+        unneeded call to core() now that coreSelection is passed directly to the function.
+        (optionFromList): Change to pass coreSelection directly to listObjectForCoreSelection().
+
 2019-07-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/accessibility/atk/WebKitAccessibleInterfaceSelection.cpp

@@ -51 +51 @@
 }
 
-static AccessibilityObject* listObjectForSelection(AtkSelection* selection)
-{
-    AccessibilityObject* coreSelection = core(selection);
-
+static AccessibilityObject* listObjectForCoreSelection(AccessibilityObject* coreSelection)
+{
     // Only list boxes and menu lists supported so far.
     if (!coreSelection->isListBox() && !coreSelection->isMenuList())
@@ -84 +82 @@
 
     // Need to select the proper list object depending on the type.
-    AccessibilityObject* listObject = listObjectForSelection(selection);
+    AccessibilityObject* listObject = listObjectForCoreSelection(coreSelection);
     if (!listObject)
         return nullptr;