Changeset 247429 in webkit

Timestamp:

Jul 15, 2019 6:39:32 AM (5 years ago)

Author:

Alan Bujtas

Message:

naver.com: Video stops when tapping on the video to use buttons
​https://bugs.webkit.org/show_bug.cgi?id=199784
<rdar://problem/48068610>

Reviewed by Maciej Stachowiak.

Opt out of simulated mouse event sending for tv.naver.com.
When tv.naver.com receives the simulated mouseUp at touchEnd, it pauses the video right away and calls preventDefault()
which prevents us from running the hover heuristics.

• page/Quirks.cpp:

(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-15  Zalan Bujtas  <zalan@apple.com>
+
+        naver.com: Video stops when tapping on the video to use buttons
+        https://bugs.webkit.org/show_bug.cgi?id=199784
+        <rdar://problem/48068610>
+
+        Reviewed by Maciej Stachowiak.
+
+        Opt out of simulated mouse event sending for tv.naver.com.
+        When tv.naver.com receives the simulated mouseUp at touchEnd, it pauses the video right away and calls preventDefault()
+        which prevents us from running the hover heuristics.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+
 2019-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -291 +291 @@
     if (equalLettersIgnoringASCIICase(host, "trailers.apple.com"))
         return true;
-    if (equalLettersIgnoringASCIICase(host, "naver.com") || host.endsWithIgnoringASCIICase(".naver.com"))
-        return true;
+    if (equalLettersIgnoringASCIICase(host, "naver.com"))
+        return true;
+    // Disable the quirk for tv.naver.com subdomain to be able to simulate hover on videos.
+    if (host.endsWithIgnoringASCIICase(".naver.com"))
+        return !equalLettersIgnoringASCIICase(host, "tv.naver.com");
     return false;
 }