Changeset 247504 in webkit


Ignore:
Timestamp:
Jul 16, 2019 9:56:36 PM (5 years ago)
Author:
Simon Fraser
Message:

Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures
https://bugs.webkit.org/show_bug.cgi?id=199849

Reviewed by Wenson Hsieh.

webkit.org/b/199587 triggered some unexpected test failures because of unified sources include
order. The TextStream operator in ScrollingTreeOverflowScrollingNode::dumpProperties() was invoking
the implicit constructor of TransformOperations.

  • page/scrolling/ScrollingTreeOverflowScrollingNode.cpp: Include TextStream.h
  • platform/graphics/transforms/TransformOperations.h: Make ctor explicit.
Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r247502 r247504  
     12019-07-16  Simon Fraser  <simon.fraser@apple.com>
     2
     3        Fix includes and make a constructor explicit to avoid unified-sources-triggered test failures
     4        https://bugs.webkit.org/show_bug.cgi?id=199849
     5
     6        Reviewed by Wenson Hsieh.
     7       
     8        webkit.org/b/199587 triggered some unexpected test failures because of unified sources include
     9        order. The TextStream operator in ScrollingTreeOverflowScrollingNode::dumpProperties() was invoking
     10        the implicit constructor of TransformOperations.
     11
     12        * page/scrolling/ScrollingTreeOverflowScrollingNode.cpp: Include TextStream.h
     13        * platform/graphics/transforms/TransformOperations.h: Make ctor explicit.
     14
    1152019-07-16  Antoine Quint  <graouts@apple.com>
    216
  • trunk/Source/WebCore/page/scrolling/ScrollingTreeOverflowScrollingNode.cpp

    r243416 r247504  
    3131#include "ScrollingStateTree.h"
    3232#include "ScrollingTree.h"
     33#include <wtf/text/TextStream.h>
    3334
    3435namespace WebCore {
  • trunk/Source/WebCore/platform/graphics/transforms/TransformOperations.h

    r234330 r247504  
    3535    WTF_MAKE_FAST_ALLOCATED;
    3636public:
    37     TransformOperations(bool makeIdentity = false);
     37    explicit TransformOperations(bool makeIdentity = false);
    3838   
    3939    bool operator==(const TransformOperations& o) const;
Note: See TracChangeset for help on using the changeset viewer.