Changeset 247568 in webkit

Timestamp:

Jul 18, 2019 11:57:35 AM (5 years ago)

Author:

graouts@webkit.org

Message:

REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS
​https://bugs.webkit.org/show_bug.cgi?id=199905
<rdar://problem/49124529>

Reviewed by Dean Jackson.

Amazon product pages include images that the user can touch and pan to show zoomed details in a side image. This
currently works on iPadOS thanks to the dispatch of simulated "mousemove" events on the product image, but the site
doesn't call preventDefault() when handling those events as it wasn't necessary for macOS.

We add a new quirk that will indicate that a given element is such a product image.

• page/Quirks.cpp:

(WebCore::Quirks::isAmazon const):
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
(WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (4 diffs)
• page/Quirks.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-18  Antoine Quint  <graouts@apple.com>
+
+        REGRESSION: Panning on an Amazon product image scrolls the page on iPadOS
+        https://bugs.webkit.org/show_bug.cgi?id=199905
+        <rdar://problem/49124529>
+
+        Reviewed by Dean Jackson.
+
+        Amazon product pages include images that the user can touch and pan to show zoomed details in a side image. This
+        currently works on iPadOS thanks to the dispatch of simulated "mousemove" events on the product image, but the site
+        doesn't call preventDefault() when handling those events as it wasn't necessary for macOS.
+
+        We add a new quirk that will indicate that a given element is such a product image.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::isAmazon const):
+        (WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):
+        (WebCore::Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented const):
+        (WebCore::Quirks::simulatedMouseEventTypeForTarget const):
+        * page/Quirks.h:
+
 2019-07-18  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -228 +228 @@
 
 #if ENABLE(TOUCH_EVENTS)
+bool Quirks::isAmazon() const
+{
+    auto& url = m_document->topDocument().url();
+    auto host = url.host();
+    return equalLettersIgnoringASCIICase(host, "amazon.com") || host.endsWithIgnoringASCIICase(".amazon.com");
+}
+
 bool Quirks::shouldDispatchSimulatedMouseEvents() const
 {
@@ -237 +244 @@
         return false;
 
-    auto& url = m_document->topDocument().url();
-    auto host = url.host();
-
-    if (equalLettersIgnoringASCIICase(host, "amazon.com") || host.endsWithIgnoringASCIICase(".amazon.com"))
-        return true;
+    if (isAmazon())
+        return true;
+
+    auto& url = m_document->topDocument().url();
+    auto host = url.host();
+
     if (equalLettersIgnoringASCIICase(host, "wix.com") || host.endsWithIgnoringASCIICase(".wix.com"))
         return true;
@@ -265 +273 @@
     if (host.endsWithIgnoringASCIICase(".naver.com"))
         return !equalLettersIgnoringASCIICase(host, "tv.naver.com");
+    return false;
+}
+
+bool Quirks::shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented(EventTarget* target) const
+{
+    if (!needsQuirks() || !shouldDispatchSimulatedMouseEvents())
+        return false;
+
+    if (isAmazon() && is<Element>(target)) {
+        // When panning on an Amazon product image, we're either touching on the #magnifierLens element
+        // or its previous sibling.
+        auto* element = downcast<Element>(target);
+        if (element->getIdAttribute() == "magnifierLens")
+            return true;
+        if (auto* sibling = element->nextElementSibling())
+            return sibling->getIdAttribute() == "magnifierLens";
+    }
+
     return false;
 }
@@ -286 +312 @@
 
     return Event::IsCancelable::Yes;
-}   
+}
 #endif
 

trunk/Source/WebCore/page/Quirks.h

@@ -51 +51 @@
 #if ENABLE(TOUCH_EVENTS)
     bool shouldDispatchSimulatedMouseEvents() const;
+    bool shouldDispatchedSimulatedMouseEventsAssumeDefaultPrevented(EventTarget*) const;
     Optional<Event::IsCancelable> simulatedMouseEventTypeForTarget(EventTarget*) const;
 #endif
@@ -71 +72 @@
     bool needsQuirks() const;
 
+#if ENABLE(TOUCH_EVENTS)
+    bool isAmazon() const;
+#endif
+
     WeakPtr<Document> m_document;