Changeset 247620 in webkit
- Timestamp:
- Jul 18, 2019 2:42:13 PM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r247573 r247620 1 2019-07-18 Per Arne Vollan <pvollan@apple.com> 2 3 Crash under WebPage::boundaryEventOccurred 4 https://bugs.webkit.org/show_bug.cgi?id=199907 5 6 Reviewed by Chris Fleizach. 7 8 Add null pointer checks. 9 10 No new tests, since I have not been able to reproduce this in a test. 11 12 * Modules/speech/SpeechSynthesis.cpp: 13 (WebCore::SpeechSynthesis::didStartSpeaking): 14 (WebCore::SpeechSynthesis::didFinishSpeaking): 15 (WebCore::SpeechSynthesis::didPauseSpeaking): 16 (WebCore::SpeechSynthesis::didResumeSpeaking): 17 (WebCore::SpeechSynthesis::speakingErrorOccurred): 18 (WebCore::SpeechSynthesis::boundaryEventOccurred): 19 1 20 2019-07-18 Antoine Quint <graouts@apple.com> 2 21 -
trunk/Source/WebCore/Modules/speech/SpeechSynthesis.cpp
r246490 r247620 226 226 void SpeechSynthesis::didStartSpeaking() 227 227 { 228 if (!m_currentSpeechUtterance) 229 return; 228 230 didStartSpeaking(*m_currentSpeechUtterance->platformUtterance()); 229 231 } … … 231 233 void SpeechSynthesis::didFinishSpeaking() 232 234 { 235 if (!m_currentSpeechUtterance) 236 return; 233 237 didFinishSpeaking(*m_currentSpeechUtterance->platformUtterance()); 234 238 } … … 236 240 void SpeechSynthesis::didPauseSpeaking() 237 241 { 242 if (!m_currentSpeechUtterance) 243 return; 238 244 didPauseSpeaking(*m_currentSpeechUtterance->platformUtterance()); 239 245 } … … 241 247 void SpeechSynthesis::didResumeSpeaking() 242 248 { 249 if (!m_currentSpeechUtterance) 250 return; 243 251 didResumeSpeaking(*m_currentSpeechUtterance->platformUtterance()); 244 252 } … … 246 254 void SpeechSynthesis::speakingErrorOccurred() 247 255 { 256 if (!m_currentSpeechUtterance) 257 return; 248 258 speakingErrorOccurred(*m_currentSpeechUtterance->platformUtterance()); 249 259 } … … 251 261 void SpeechSynthesis::boundaryEventOccurred(bool wordBoundary, unsigned charIndex) 252 262 { 263 if (!m_currentSpeechUtterance) 264 return; 253 265 boundaryEventOccurred(*m_currentSpeechUtterance->platformUtterance(), wordBoundary ? SpeechBoundary::SpeechWordBoundary : SpeechBoundary::SpeechSentenceBoundary, charIndex); 254 266 }
Note: See TracChangeset
for help on using the changeset viewer.