Changeset 247746 in webkit

Timestamp:

Jul 23, 2019 2:49:00 PM (5 years ago)

Author:

Alan Bujtas

Message:

[iOS] Tapping the search field on a search results page on zillow.com shows and immediately dismisses the keyboard
​https://bugs.webkit.org/show_bug.cgi?id=200044
<rdar://problem/53103732>

Reviewed by Wenson Hsieh.

Source/WebCore:

1. The keyboard gets dismissed as the result of scroll event.
2. The (horizontal)scroll event is initiated by WebKit as we try to re-center the content.
3. The content gets off-centered as the result of the newly constructed drop-down menu which slightly sticks out of the document to the right (layout overflows).

It works with shipping version of iOS because _zoomToFocusRect operates on stale viewport information (see r244494 for the progression).
This patch applies a site specific quirk to restore shipping behavior.

• page/Quirks.cpp:

(WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):

• page/Quirks.h:

Source/WebKit:

• Shared/FocusedElementInformation.cpp:

(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

• Shared/FocusedElementInformation.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidBlur]):
(-[WKContentView _shouldAvoidScrollingWhenFocusedContentIsVisible]):

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getFocusedElementInformation):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/Quirks.cpp (modified) (1 diff)
• WebCore/page/Quirks.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/FocusedElementInformation.cpp (modified) (2 diffs)
• WebKit/Shared/FocusedElementInformation.h (modified) (1 diff)
• WebKit/UIProcess/API/Cocoa/WKWebView.mm (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.h (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (2 diffs)
• WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-23  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] Tapping the search field on a search results page on zillow.com shows and immediately dismisses the keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=200044
+        <rdar://problem/53103732>
+
+        Reviewed by Wenson Hsieh.
+
+        1. The keyboard gets dismissed as the result of scroll event.
+        2. The (horizontal)scroll event is initiated by WebKit as we try to re-center the content.
+        3. The content gets off-centered as the result of the newly constructed drop-down menu which slightly sticks out of the document to the right (layout overflows).
+
+        It works with shipping version of iOS because _zoomToFocusRect operates on stale viewport information (see r244494 for the progression).
+        This patch applies a site specific quirk to restore shipping behavior.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible const):
+        * page/Quirks.h:
+
 2019-07-23  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -438 +438 @@
 }
 
-}
+bool Quirks::shouldAvoidScrollingWhenFocusedContentIsVisible() const
+{
+    if (!needsQuirks())
+        return false;
+
+    return equalLettersIgnoringASCIICase(m_document->url().host(), "www.zillow.com");
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -63 +63 @@
     WEBCORE_EXPORT bool isNeverRichlyEditableForTouchBar() const;
     WEBCORE_EXPORT bool shouldAvoidResizingWhenInputViewBoundsChange() const;
+    WEBCORE_EXPORT bool shouldAvoidScrollingWhenFocusedContentIsVisible() const;
 
     WEBCORE_EXPORT bool needsYouTubeMouseOutQuirk() const;

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-23  Zalan Bujtas  <zalan@apple.com>
+
+        [iOS] Tapping the search field on a search results page on zillow.com shows and immediately dismisses the keyboard
+        https://bugs.webkit.org/show_bug.cgi?id=200044
+        <rdar://problem/53103732>
+
+        Reviewed by Wenson Hsieh.
+
+        * Shared/FocusedElementInformation.cpp:
+        (WebKit::FocusedElementInformation::encode const):
+        (WebKit::FocusedElementInformation::decode):
+        * Shared/FocusedElementInformation.h:
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):
+        * UIProcess/ios/WKContentViewInteraction.h:
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView _elementDidBlur]):
+        (-[WKContentView _shouldAvoidScrollingWhenFocusedContentIsVisible]):
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::getFocusedElementInformation):
+
 2019-07-23  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/FocusedElementInformation.cpp

@@ -108 +108 @@
     encoder << isSpellCheckingEnabled;
     encoder << shouldAvoidResizingWhenInputViewBoundsChange;
+    encoder << shouldAvoidScrollingWhenFocusedContentIsVisible;
 }
 
@@ -235 +236 @@
         return false;
 
+    if (!decoder.decode(result.shouldAvoidScrollingWhenFocusedContentIsVisible))
+        return false;
+
     return true;
 }

trunk/Source/WebKit/Shared/FocusedElementInformation.h

@@ -140 +140 @@
     bool isSpellCheckingEnabled { true };
     bool shouldAvoidResizingWhenInputViewBoundsChange { false };
+    bool shouldAvoidScrollingWhenFocusedContentIsVisible { false };
 
     FocusedElementIdentifier focusedElementIdentifier { 0 };

trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

@@ -2423 +2423 @@
 
     BOOL selectionRectIsNotNull = !selectionRectInDocumentCoordinates.isZero();
-    if (!forceScroll) {
+    BOOL doNotScrollWhenContentIsAlreadyVisible = !forceScroll || [_contentView _shouldAvoidScrollingWhenFocusedContentIsVisible];
+    if (doNotScrollWhenContentIsAlreadyVisible) {
         CGRect currentlyVisibleRegionInWebViewCoordinates;
         currentlyVisibleRegionInWebViewCoordinates.origin = unobscuredScrollViewRectInWebViewCoordinates.origin;

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h

@@ -539 +539 @@
 @property (nonatomic, readonly) BOOL _shouldUseContextMenus;
 @property (nonatomic, readonly) BOOL _shouldAvoidResizingWhenInputViewBoundsChange;
+@property (nonatomic, readonly) BOOL _shouldAvoidScrollingWhenFocusedContentIsVisible;
 
 @end

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -5401 +5401 @@
     _focusedElementInformation.shouldSynthesizeKeyEventsForEditing = false;
     _focusedElementInformation.shouldAvoidResizingWhenInputViewBoundsChange = false;
+    _focusedElementInformation.shouldAvoidScrollingWhenFocusedContentIsVisible = false;
     _inputPeripheral = nil;
     _focusRequiresStrongPasswordAssistance = NO;
@@ -6350 +6351 @@
 {
     return _focusedElementInformation.shouldAvoidResizingWhenInputViewBoundsChange;
+}
+
+- (BOOL)_shouldAvoidScrollingWhenFocusedContentIsVisible
+{
+    return _focusedElementInformation.shouldAvoidScrollingWhenFocusedContentIsVisible;
 }
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -3054 +3054 @@
     }
 
-    information.shouldAvoidResizingWhenInputViewBoundsChange = m_focusedElement->document().quirks().shouldAvoidResizingWhenInputViewBoundsChange();
+    auto& quirks = m_focusedElement->document().quirks();
+    information.shouldAvoidResizingWhenInputViewBoundsChange = quirks.shouldAvoidResizingWhenInputViewBoundsChange();
+    information.shouldAvoidScrollingWhenFocusedContentIsVisible = quirks.shouldAvoidScrollingWhenFocusedContentIsVisible();
 }