Changeset 247873 in webkit

Timestamp:

Jul 26, 2019 1:34:28 PM (5 years ago)

Author:

youenn@apple.com

Message:

slides.google.com: opening speaker notes while presenting causes a fatal error in the web app on iPad
​https://bugs.webkit.org/show_bug.cgi?id=199933
<rdar://problem/53034345>

Reviewed by Darin Adler.

docs.google.com might sometimes try to window.open an about URL that not about:blank or about:srcdoc.
In that case, WebKit is opening a window but is considering that the window is cross origin with its opener.
This breaks docs.google.com as they want to access the website.
Add a site-specific hack so as to treat all about URLs being opened through window.open as about:blank.

Manually tested on docs.google.com website.

• page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::open):

• page/Quirks.cpp:

(WebCore::Quirks::needsYouTubeOverflowScrollQuirk const):
(WebCore::Quirks::shouldOpenAsAboutBlank const):

• page/Quirks.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/DOMWindow.cpp (modified) (2 diffs)
• page/Quirks.cpp (modified) (2 diffs)
• page/Quirks.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-07-26  Youenn Fablet  <youenn@apple.com>
+
+        slides.google.com: opening speaker notes while presenting causes a fatal error in the web app on iPad
+        https://bugs.webkit.org/show_bug.cgi?id=199933
+        <rdar://problem/53034345>
+
+        Reviewed by Darin Adler.
+
+        docs.google.com might sometimes try to window.open an about URL that not about:blank or about:srcdoc.
+        In that case, WebKit is opening a window but is considering that the window is cross origin with its opener.
+        This breaks docs.google.com as they want to access the website.
+        Add a site-specific hack so as to treat all about URLs being opened through window.open as about:blank.
+
+        Manually tested on docs.google.com website.
+
+        * page/DOMWindow.cpp:
+        (WebCore::DOMWindow::createWindow):
+        (WebCore::DOMWindow::open):
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsYouTubeOverflowScrollQuirk const):
+        (WebCore::Quirks::shouldOpenAsAboutBlank const):
+        * page/Quirks.h:
+
 2019-07-26  Alexander Mikhaylenko  <exalm7659@gmail.com>
 

trunk/Source/WebCore/page/DOMWindow.cpp

@@ -2396 +2396 @@
 }
 
-ExceptionOr<RefPtr<WindowProxy>> DOMWindow::open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlString, const AtomString& frameName, const String& windowFeaturesString)
+ExceptionOr<RefPtr<WindowProxy>> DOMWindow::open(DOMWindow& activeWindow, DOMWindow& firstWindow, const String& urlStringToOpen, const AtomString& frameName, const String& windowFeaturesString)
 {
     if (!isCurrentlyDisplayedInFrame())
@@ -2408 +2408 @@
     if (!firstFrame)
         return RefPtr<WindowProxy> { nullptr };
+
+    auto urlString = urlStringToOpen;
+    if (activeDocument->quirks().shouldOpenAsAboutBlank(urlStringToOpen))
+        urlString = "about:blank"_s;
 
 #if ENABLE(CONTENT_EXTENSIONS)

trunk/Source/WebCore/page/Quirks.cpp

@@ -31 +31 @@
 #include "Document.h"
 #include "DocumentLoader.h"
+#include "FrameLoader.h"
 #include "HTMLMetaElement.h"
 #include "HTMLObjectElement.h"
@@ -456 +457 @@
 }
 
-}
+bool Quirks::shouldOpenAsAboutBlank(const String& stringToOpen) const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    auto openerURL = m_document->url();
+    if (!equalLettersIgnoringASCIICase(openerURL.host(), "docs.google.com"))
+        return false;
+
+    if (!m_document->frame() || !m_document->frame()->loader().userAgentForJavaScript(openerURL).contains("Macintosh"))
+        return false;
+
+    URL urlToOpen { URL { }, stringToOpen };
+    if (!urlToOpen.protocolIsAbout())
+        return false;
+
+    return !equalLettersIgnoringASCIICase(urlToOpen.host(), "blank") && !equalLettersIgnoringASCIICase(urlToOpen.host(), "srcdoc");
+#else
+    UNUSED_PARAM(stringToOpen);
+    return false;
+#endif
+}
+
+}

trunk/Source/WebCore/page/Quirks.h

@@ -71 +71 @@
     bool needsYouTubeOverflowScrollQuirk() const;
 
+    bool shouldOpenAsAboutBlank(const String&) const;
+
 private:
     bool needsQuirks() const;