Changeset 247891 in webkit


Ignore:
Timestamp:
Jul 27, 2019 5:42:36 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Expose the aria-label attribute for <video> elements.
​https://bugs.webkit.org/show_bug.cgi?id=200169
<rdar://problem/51754558>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-07-27
Reviewed by Chris Fleizach.

Source/WebCore:

Tests: accessibility/ios-simulator/media-with-aria-label.html

accessibility/media-with-aria-label.html

We now expose the <video> element to accessibility clients as long as auto-play is not enabled.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityIsWebInteractiveVideo]):

LayoutTests:

  • accessibility/ios-simulator/media-with-aria-label-expected.txt: Added.
  • accessibility/ios-simulator/media-with-aria-label.html: Added.
  • accessibility/media-with-aria-label-expected.txt: Added.
  • accessibility/media-with-aria-label.html: Added.
  • platform/win/TestExpectations:
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r247881 r247891  
     12019-07-27  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Expose the aria-label attribute for <video> elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=200169
     5        <rdar://problem/51754558>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        * accessibility/ios-simulator/media-with-aria-label-expected.txt: Added.
     10        * accessibility/ios-simulator/media-with-aria-label.html: Added.
     11        * accessibility/media-with-aria-label-expected.txt: Added.
     12        * accessibility/media-with-aria-label.html: Added.
     13        * platform/win/TestExpectations:
     14
    1152019-07-26  Ryosuke Niwa  <rniwa@webkit.org>
    216

  • trunk/LayoutTests/platform/win/TestExpectations

    r247860 r247891  
    17011701# Not implemented on Win
    17021702accessibility/insert-newline.html [ Skip ]
     1703accessibility/media-with-aria-label.html [ Skip ]
    17031704
    17041705################################################################################

  • trunk/Source/WebCore/ChangeLog

    r247887 r247891  
     12019-07-27  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Expose the aria-label attribute for <video> elements.
     4        https://bugs.webkit.org/show_bug.cgi?id=200169
     5        <rdar://problem/51754558>
     6
     7        Reviewed by Chris Fleizach.
     8
     9        Tests: accessibility/ios-simulator/media-with-aria-label.html
     10               accessibility/media-with-aria-label.html
     11
     12        We now expose the <video> element to accessibility clients as long as auto-play is not enabled.
     13        * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
     14        (-[WebAccessibilityObjectWrapper accessibilityIsWebInteractiveVideo]):
     15
    1162019-07-26  Saam Barati  <sbarati@apple.com>
    217

  • trunk/Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm

    r247677 r247891  
    683683    if (![self _prepareAccessibilityCall])
    684684        return NO;
    685    
    686     // Only make the video object interactive if it plays inline and has no native controls.
     685
    687686    if (m_object->roleValue() != AccessibilityRole::Video || !is<AccessibilityMediaObject>(m_object))
    688687        return NO;
    689    
    690     AccessibilityMediaObject* mediaObject = downcast<AccessibilityMediaObject>(m_object);
    691     return !mediaObject->isAutoplayEnabled() && mediaObject->isPlayingInline() && !downcast<AccessibilityMediaObject>(m_object)->hasControlsAttributeSet();
     688
     689    // Convey the video object as interactive if auto-play is not enabled.
     690    return !downcast<AccessibilityMediaObject>(*m_object).isAutoplayEnabled();
    692691}
    693692
Note: See TracChangeset for help on using the changeset viewer.