Changeset 248006 in webkit

Timestamp:

Jul 30, 2019 8:40:01 AM (5 years ago)

Author:

Truitt Savell

Message:

Unreviewed, rolling out r247932.

Broke 8 API tests across all platforms.

Reverted changeset:

"Fix non-thread safe use of WeakPtr under
sendSecItemRequest()"
​https://bugs.webkit.org/show_bug.cgi?id=200249
​https://trac.webkit.org/changeset/247932

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/mac/SecItemShim.cpp (modified) (1 diff)
• UIProcess/mac/SecItemShimProxy.cpp (modified) (1 diff)
• UIProcess/mac/SecItemShimProxy.h (modified) (1 diff)
• UIProcess/mac/SecItemShimProxy.messages.in (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-07-30  Truitt Savell  <tsavell@apple.com>
+
+        Unreviewed, rolling out r247932.
+
+        Broke 8 API tests across all platforms.
+
+        Reverted changeset:
+
+        "Fix non-thread safe use of WeakPtr under
+        sendSecItemRequest()"
+        https://bugs.webkit.org/show_bug.cgi?id=200249
+        https://trac.webkit.org/changeset/247932
+
 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/Shared/mac/SecItemShim.cpp

@@ -65 +65 @@
 }
 
+static WorkQueue& workQueue()
+{
+    static WorkQueue* workQueue;
+    static dispatch_once_t onceToken;
+    dispatch_once(&onceToken, ^{
+        workQueue = &WorkQueue::create("com.apple.WebKit.SecItemShim").leakRef();
+
+    });
+
+    return *workQueue;
+}
+
 static Optional<SecItemResponseData> sendSecItemRequest(SecItemRequestData::Type requestType, CFDictionaryRef query, CFDictionaryRef attributesToMatch = 0)
 {
+    if (!globalNetworkProcess())
+        return WTF::nullopt;
+
     Optional<SecItemResponseData> response;
 
     BinarySemaphore semaphore;
-    RunLoop::main().dispatch([&] {
-        if (!globalNetworkProcess()) {
-            semaphore.signal();
-            return;
-        }
-        globalNetworkProcess()->parentProcessConnection()->sendWithAsyncReply(Messages::SecItemShimProxy::SecItemRequest(SecItemRequestData(requestType, query, attributesToMatch)), [&](auto reply) {
-            if (reply)
-                response = WTFMove(*reply);
 
-            semaphore.signal();
-        });
+    globalNetworkProcess()->parentProcessConnection()->sendWithReply(Messages::SecItemShimProxy::SecItemRequest(SecItemRequestData(requestType, query, attributesToMatch)), 0, workQueue(), [&response, &semaphore](auto reply) {
+        if (reply)
+            response = WTFMove(std::get<0>(*reply));
+
+        semaphore.signal();
     });
 

trunk/Source/WebKit/UIProcess/mac/SecItemShimProxy.cpp

@@ -57 +57 @@
 }
 
-void SecItemShimProxy::secItemRequest(const SecItemRequestData& request, CompletionHandler<void(Optional<SecItemResponseData>&&)>&& response)
+void SecItemShimProxy::didReceiveMessage(IPC::Connection&, IPC::Decoder&)
+{
+}
+
+void SecItemShimProxy::secItemRequest(const SecItemRequestData& request, CompletionHandler<void(SecItemResponseData&&)>&& response)
 {
     switch (request.type()) {

trunk/Source/WebKit/UIProcess/mac/SecItemShimProxy.h

@@ -47 +47 @@
     // IPC::Connection::WorkQueueMessageReceiver
     void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
+    void didReceiveSyncMessage(IPC::Connection&, IPC::Decoder&, std::unique_ptr<IPC::Encoder>&) override;
 
-    void secItemRequest(const SecItemRequestData&, CompletionHandler<void(Optional<SecItemResponseData>&&)>&&);
+    void secItemRequest(const SecItemRequestData&, CompletionHandler<void(SecItemResponseData&&)>&&);
 
     Ref<WorkQueue> m_queue;

trunk/Source/WebKit/UIProcess/mac/SecItemShimProxy.messages.in

@@ -24 +24 @@
 
 #if ENABLE(SEC_ITEM_SHIM)
-    SecItemRequest(WebKit::SecItemRequestData request) -> (Optional<WebKit::SecItemResponseData> response) Async
+    SecItemRequest(WebKit::SecItemRequestData request) -> (WebKit::SecItemResponseData response) Synchronous
 #endif