Changeset 248015 in webkit

Timestamp:

Jul 30, 2019 1:21:25 PM (5 years ago)

Author:

Simon Fraser

Message:

Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)
​https://bugs.webkit.org/show_bug.cgi?id=200263
rdar://problem/53679408

Reviewed by Antti Koivisto.

Source/WebKit:

The content on this page had a scale(0) div overlaying an overflow:scroll element,
and our UI-side hit-testing code would find this scale(0) element, because apparently
-[UIView convertPoint:fromView:] will happily work with non-invertible matrices, and
-[UIView pointInside:withEvent:] just compares the point with the view bounds.

Since the view frame takes the transform into account, we can look for an empty frame
to detect these non-invertible transforms.

• UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:

(WebKit::collectDescendantViewsAtPoint):

LayoutTests:

• fast/scrolling/ios/non-invertible-transformed-over-scroller-expected.txt: Added.
• fast/scrolling/ios/non-invertible-transformed-over-scroller.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/scrolling/ios/non-invertible-transformed-over-scroller-expected.txt (added)
• LayoutTests/fast/scrolling/ios/non-invertible-transformed-over-scroller.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ -119 +119 @@
         * compositing/shared-backing/backing-sharing-repaint-expected.html: Added.
         * compositing/shared-backing/backing-sharing-repaint.html: Added.
+
+2019-07-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)
+        https://bugs.webkit.org/show_bug.cgi?id=200263
+        rdar://problem/53679408
+
+        Reviewed by Antti Koivisto.
+
+        * fast/scrolling/ios/non-invertible-transformed-over-scroller-expected.txt: Added.
+        * fast/scrolling/ios/non-invertible-transformed-over-scroller.html: Added.
 
 2019-07-29  Simon Fraser  <simon.fraser@apple.com>

trunk/Source/WebKit/ChangeLog

@@ -318 +318 @@
         context to ensure that the completion handler for the nested request is invoked before the outer request is
         finished.
+
+2019-07-29  Simon Fraser  <simon.fraser@apple.com>
+
+        Can't scroll on yummly.co.uk recipe (scale(0) div covers the content and hit-tests)
+        https://bugs.webkit.org/show_bug.cgi?id=200263
+        rdar://problem/53679408
+
+        Reviewed by Antti Koivisto.
+
+        The content on this page had a scale(0) div overlaying an overflow:scroll element,
+        and our UI-side hit-testing code would find this scale(0) element, because apparently
+        -[UIView convertPoint:fromView:] will happily work with non-invertible matrices, and 
+        -[UIView pointInside:withEvent:] just compares the point with the view bounds.
+
+        Since the view frame takes the transform into account, we can look for an empty frame
+        to detect these non-invertible transforms.
+
+        * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
+        (WebKit::collectDescendantViewsAtPoint):
 
 2019-07-29  Youenn Fablet  <youenn@apple.com>

trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm

@@ -53 +53 @@
             if (!view.isUserInteractionEnabled)
                 return false;
+
+            if (CGRectIsEmpty([view frame]))
+                return false;
+
             if (![view pointInside:subviewPoint withEvent:event])
                 return false;
+
             if (![view isKindOfClass:[WKCompositingView class]])
                 return true;