Changeset 248034 in webkit


Ignore:
Timestamp:
Jul 31, 2019 1:53:39 AM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Second call to setAttributeNS creates non-prefixed attribute
https://bugs.webkit.org/show_bug.cgi?id=200230
<rdar://problem/53712672>

Reviewed by Joseph Pecoraro.

Source/WebCore:

Original patch by Chris Dumez <Chris Dumez>.

Test: inspector/dom/attributeModified.html

  • dom/Element.cpp:

(WebCore::Element::didAddAttribute):
(WebCore::Element::didModifyAttribute):
(WebCore::Element::didRemoveAttribute):
Use the fully qualified name, not just the local name, when notifying the inspector frontend
about changes to attributes.

LayoutTests:

  • inspector/dom/attributeModified.html: Added.
  • inspector/dom/attributeModified-expected.txt: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r248033 r248034  
     12019-07-31  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Second call to setAttributeNS creates non-prefixed attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=200230
     5        <rdar://problem/53712672>
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        * inspector/dom/attributeModified.html: Added.
     10        * inspector/dom/attributeModified-expected.txt: Added.
     11
    1122019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
    213
  • trunk/Source/WebCore/ChangeLog

    r248033 r248034  
     12019-07-31  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Second call to setAttributeNS creates non-prefixed attribute
     4        https://bugs.webkit.org/show_bug.cgi?id=200230
     5        <rdar://problem/53712672>
     6
     7        Reviewed by Joseph Pecoraro.
     8
     9        Original patch by Chris Dumez <cdumez@apple.com>.
     10
     11        Test: inspector/dom/attributeModified.html
     12
     13        * dom/Element.cpp:
     14        (WebCore::Element::didAddAttribute):
     15        (WebCore::Element::didModifyAttribute):
     16        (WebCore::Element::didRemoveAttribute):
     17        Use the fully qualified name, not just the local name, when notifying the inspector frontend
     18        about changes to attributes.
     19
    1202019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
    221
  • trunk/Source/WebCore/dom/Element.cpp

    r247306 r248034  
    38533853{
    38543854    attributeChanged(name, nullAtom(), value);
    3855     InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.localName(), value);
     3855    InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.toString(), value);
    38563856    dispatchSubtreeModifiedEvent();
    38573857}
     
    38603860{
    38613861    attributeChanged(name, oldValue, newValue);
    3862     InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.localName(), newValue);
     3862    InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.toString(), newValue);
    38633863    // Do not dispatch a DOMSubtreeModified event here; see bug 81141.
    38643864}
     
    38673867{
    38683868    attributeChanged(name, oldValue, nullAtom());
    3869     InspectorInstrumentation::didRemoveDOMAttr(document(), *this, name.localName());
     3869    InspectorInstrumentation::didRemoveDOMAttr(document(), *this, name.toString());
    38703870    dispatchSubtreeModifiedEvent();
    38713871}
Note: See TracChangeset for help on using the changeset viewer.