Changeset 248034 in webkit
- Timestamp:
- Jul 31, 2019 1:53:39 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r248033 r248034 1 2019-07-31 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Second call to setAttributeNS creates non-prefixed attribute 4 https://bugs.webkit.org/show_bug.cgi?id=200230 5 <rdar://problem/53712672> 6 7 Reviewed by Joseph Pecoraro. 8 9 * inspector/dom/attributeModified.html: Added. 10 * inspector/dom/attributeModified-expected.txt: Added. 11 1 12 2019-07-31 Carlos Garcia Campos <cgarcia@igalia.com> 2 13 -
trunk/Source/WebCore/ChangeLog
r248033 r248034 1 2019-07-31 Devin Rousso <drousso@apple.com> 2 3 Web Inspector: Second call to setAttributeNS creates non-prefixed attribute 4 https://bugs.webkit.org/show_bug.cgi?id=200230 5 <rdar://problem/53712672> 6 7 Reviewed by Joseph Pecoraro. 8 9 Original patch by Chris Dumez <cdumez@apple.com>. 10 11 Test: inspector/dom/attributeModified.html 12 13 * dom/Element.cpp: 14 (WebCore::Element::didAddAttribute): 15 (WebCore::Element::didModifyAttribute): 16 (WebCore::Element::didRemoveAttribute): 17 Use the fully qualified name, not just the local name, when notifying the inspector frontend 18 about changes to attributes. 19 1 20 2019-07-31 Carlos Garcia Campos <cgarcia@igalia.com> 2 21 -
trunk/Source/WebCore/dom/Element.cpp
r247306 r248034 3853 3853 { 3854 3854 attributeChanged(name, nullAtom(), value); 3855 InspectorInstrumentation::didModifyDOMAttr(document(), *this, name. localName(), value);3855 InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.toString(), value); 3856 3856 dispatchSubtreeModifiedEvent(); 3857 3857 } … … 3860 3860 { 3861 3861 attributeChanged(name, oldValue, newValue); 3862 InspectorInstrumentation::didModifyDOMAttr(document(), *this, name. localName(), newValue);3862 InspectorInstrumentation::didModifyDOMAttr(document(), *this, name.toString(), newValue); 3863 3863 // Do not dispatch a DOMSubtreeModified event here; see bug 81141. 3864 3864 } … … 3867 3867 { 3868 3868 attributeChanged(name, oldValue, nullAtom()); 3869 InspectorInstrumentation::didRemoveDOMAttr(document(), *this, name. localName());3869 InspectorInstrumentation::didRemoveDOMAttr(document(), *this, name.toString()); 3870 3870 dispatchSubtreeModifiedEvent(); 3871 3871 }
Note: See TracChangeset
for help on using the changeset viewer.