Changeset 248044 in webkit

Timestamp:

Jul 31, 2019 9:26:57 AM (5 years ago)

Author:

Keith Rollin

Message:

Fix 64-bit vs 32-bit mismatch in PersistentCoders.h
​https://bugs.webkit.org/show_bug.cgi?id=200288
<rdar://problem/53734203>

Reviewed by Chris Dumez.

hashMapSize is declared as a uint64_t. It is passed to
HashMapType::reserveInitialCapacity, which takes an unsigned int. This
is a 32-bit value on 32-bit platforms, leading to a compile time
error. Fix his by casting hashMapSize to the expected type.

• wtf/persistence/PersistentCoders.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/persistence/PersistentCoders.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-07-31  Keith Rollin  <krollin@apple.com>
+
+        Fix 64-bit vs 32-bit mismatch in PersistentCoders.h
+        https://bugs.webkit.org/show_bug.cgi?id=200288
+        <rdar://problem/53734203>
+
+        Reviewed by Chris Dumez.
+
+        hashMapSize is declared as a uint64_t. It is passed to
+        HashMapType::reserveInitialCapacity, which takes an unsigned int. This
+        is a 32-bit value on 32-bit platforms, leading to a compile time
+        error. Fix his by casting hashMapSize to the expected type.
+
+        * wtf/persistence/PersistentCoders.h:
+
 2019-07-31  Keith Rollin  <krollin@apple.com>
 

trunk/Source/WTF/wtf/persistence/PersistentCoders.h

@@ -197 +197 @@
 
         HashMapType tempHashMap;
-        tempHashMap.reserveInitialCapacity(hashMapSize);
+        tempHashMap.reserveInitialCapacity(static_cast<unsigned>(hashMapSize));
         for (uint64_t i = 0; i < hashMapSize; ++i) {
             KeyArg key;