Changeset 248174 in webkit

Timestamp:

Aug 2, 2019 1:09:06 PM (5 years ago)

Author:

jer.noble@apple.com

Message:

[iPadOS] slides.google.com: Full Screen API warning is presented when swiping through slides
​https://bugs.webkit.org/show_bug.cgi?id=200313
<rdar://problem/53777001>

Reviewed by Eric Carlson.

Only run the secheuristic scoring during UIGestureRecognizerStateEnded, rather than both
UIGestureRecognizerStateEnded and UIGestureRecognizerStateBegan. The goal of the heuristic is
to detect fake on-screen keyboards by detecting gestures that look like "typing". Using only
UIGestureRecognizerStateEnded still allows us to do this (as typing will usually have identical
geometries for both Ended and Began) without generating false-positives during swipe gestures.

• UIProcess/ios/fullscreen/WKFullScreenViewController.mm:

(-[WKFullScreenViewController _touchDetected:]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/fullscreen/WKFullScreenViewController.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-02  Jer Noble  <jer.noble@apple.com>
+
+        [iPadOS] slides.google.com: Full Screen API warning is presented when swiping through slides
+        https://bugs.webkit.org/show_bug.cgi?id=200313
+        <rdar://problem/53777001>
+
+        Reviewed by Eric Carlson.
+
+        Only run the secheuristic scoring during UIGestureRecognizerStateEnded, rather than both
+        UIGestureRecognizerStateEnded and UIGestureRecognizerStateBegan. The goal of the heuristic is
+        to detect fake on-screen keyboards by detecting gestures that look like "typing". Using only
+        UIGestureRecognizerStateEnded still allows us to do this (as typing will usually have identical
+        geometries for both Ended and Began) without generating false-positives during swipe gestures.
+
+        * UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
+        (-[WKFullScreenViewController _touchDetected:]):
+
 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

@@ -530 +530 @@
 - (void)_touchDetected:(id)sender
 {
-    if ([_touchGestureRecognizer state] == UIGestureRecognizerStateBegan || [_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
+    if ([_touchGestureRecognizer state] == UIGestureRecognizerStateEnded) {
         double score = _secheuristic.scoreOfNextTouch([_touchGestureRecognizer locationInView:self.view]);
         if (score > requiredScore)