Changeset 248189 in webkit

Timestamp:

Aug 2, 2019 4:20:31 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[ Mac ] Layout Test accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=196505
<rdar://problem/49532620>

Patch by Andres Gonzalez <Andres Gonzalez> on 2019-08-02
Reviewed by Chris Fleizach.

Re-wrote test in a timing independent way. This should fix the intermittent failures.

• accessibility/mac/press-not-work-for-disabled-menu-list.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• accessibility/mac/press-not-work-for-disabled-menu-list.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
+
+        [ Mac ] Layout Test accessibility/mac/press-not-work-for-disabled-menu-list.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=196505
+        <rdar://problem/49532620>
+
+        Reviewed by Chris Fleizach.
+
+        Re-wrote test in a timing independent way. This should fix the intermittent failures.
+        * accessibility/mac/press-not-work-for-disabled-menu-list.html:
+
 2019-08-02  Yury Semikhatsky  <yurys@chromium.org>
 

trunk/LayoutTests/accessibility/mac/press-not-work-for-disabled-menu-list.html

@@ -43 +43 @@
 
     // We don't test for enabled controls because opening menu lists waits on the UI process to display the menu.
-    var numOfTests = 3, notificationCount = 0;
+    var testCount = 3, testIndex = 0;
     var lists = [null, null, null];
-    if (window.accessibilityController) {
-        jsTestIsAsync = true;
-        pressNext(0);
-    }
 
-    function pressNext(testId) {
-        if (testId > numOfTests)
+    function testNextList() {
+        if (testIndex >= testCount) {
+            finishJSTest();
             return;
-        var menulist = accessibilityController.accessibleElementById("test" + testId);
+        }
+
+        var menulist = accessibilityController.accessibleElementById("test" + testIndex);
         menulist.addNotificationListener(pressListener);
         menulist.press();
-        lists[testId] = menulist;
-        window.setTimeout(function() {
-            pressNext(testId + 1);
-        }, 0);
+        lists[testIndex] = menulist;
     }
 
     function pressListener(notification) {
-        if (notification == "AXPressDidFail" || notification == "AXPressDidSucceed")
-            notificationCount++;
+        lists[testIndex].removeNotificationListener(pressListener);
 
         debug("Got notification: " + notification);
-        lists[notificationCount-1].removeNotificationListener(pressListener);
-        if (notificationCount == numOfTests) {
-            finishJSTest();
-        }
+
+        testIndex++;
+        testNextList();
+    }
+
+    if (window.accessibilityController) {
+        jsTestIsAsync = true;
+        testNextList();
     }
 </script>