Changeset 248463 in webkit

Timestamp:

Aug 9, 2019 12:17:44 AM (5 years ago)

Author:

rniwa@webkit.org

Message:

REGRESSION (iOS 13): united.com web forms do not respond to taps
​https://bugs.webkit.org/show_bug.cgi?id=200531

Reviewed by Antti Koivisto and Wenson Hsieh.

The bug is caused by the content change observer detecting “Site Feedback” link at the bottom of
the page (​https://www.united.com/ual/en/US/account/enroll/default) constantly getting re-generated
in every frame via requestAnimationFrame when the page is opened with iPhone UA string.
Note that the content re-generation can be reproduced even in Chrome if iPhone UA string is used.

Ignore this constant content change in ContentChangeObserver as a site specific quirk.

In the future, we should make ContentChangeObserver observe the final location of each element
being observed so that we can ignore content that like this which is placed outside the viewport,
and/or far away from where the user tapped.

• page/Quirks.cpp:

(WebCore::Quirks::shouldIgnoreContentChange const): Added.

• page/Quirks.h:
• page/ios/ContentChangeObserver.cpp:

(WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)
• page/Quirks.h (modified) (2 diffs)
• page/ios/ContentChangeObserver.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-08-09  Ryosuke Niwa  <rniwa@webkit.org>
+
+        REGRESSION (iOS 13): united.com web forms do not respond to taps
+        https://bugs.webkit.org/show_bug.cgi?id=200531
+
+        Reviewed by Antti Koivisto and Wenson Hsieh.
+
+        The bug is caused by the content change observer detecting “Site Feedback” link at the bottom of
+        the page (https://www.united.com/ual/en/US/account/enroll/default) constantly getting re-generated
+        in every frame via requestAnimationFrame when the page is opened with iPhone UA string.
+        Note that the content re-generation can be reproduced even in Chrome if iPhone UA string is used.
+
+        Ignore this constant content change in ContentChangeObserver as a site specific quirk.
+
+        In the future, we should make ContentChangeObserver observe the final location of each element
+        being observed so that we can ignore content that like this which is placed outside the viewport,
+        and/or far away from where the user tapped.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::shouldIgnoreContentChange const): Added.
+        * page/Quirks.h:
+        * page/ios/ContentChangeObserver.cpp:
+        (WebCore::ContentChangeObserver::shouldObserveVisibilityChangeForElement):
+
 2019-08-08  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -411 +411 @@
 }
 
+bool Quirks::shouldIgnoreContentChange(const Element& element) const
+{
+#if PLATFORM(IOS_FAMILY)
+    if (!needsQuirks())
+        return false;
+
+    auto* parentElement = element.parentElement();
+    if (!parentElement || !parentElement->hasClass())
+        return false;
+
+    DOMTokenList& classList = parentElement->classList();
+    if (!classList.contains("feedback") || !classList.contains("feedback-mid"))
+        return false;
+
+    if (!equalLettersIgnoringASCIICase(topPrivatelyControlledDomain(m_document->url().host().toString()), "united.com"))
+        return false;
+
+    return true;
+#else
+    UNUSED_PARAM(element);
+    return false;
+#endif
+}
+
 // FIXME(<rdar://problem/50394969>): Remove after desmos.com adopts inputmode="none".
 bool Quirks::needsInputModeNoneImplicitly(const HTMLElement& element) const

trunk/Source/WebCore/page/Quirks.h

@@ -32 +32 @@
 
 class Document;
+class Element;
 class EventTarget;
 class HTMLElement;
@@ -56 +57 @@
 #endif
     bool shouldDisablePointerEventsQuirk() const;
+    bool shouldIgnoreContentChange(const Element&) const;
     bool needsInputModeNoneImplicitly(const HTMLElement&) const;
     bool needsDeferKeyDownAndKeyPressTimersUntilNextEditingCommand() const;

trunk/Source/WebCore/page/ios/ContentChangeObserver.cpp

@@ -37 +37 @@
 #include "NodeRenderStyle.h"
 #include "Page.h"
+#include "Quirks.h"
 #include "RenderDescendantIterator.h"
 #include "Settings.h"
@@ -597 +598 @@
 bool ContentChangeObserver::shouldObserveVisibilityChangeForElement(const Element& element)
 {
-    return isObservingContentChanges() && !hasVisibleChangeState() && !visibleRendererWasDestroyed(element);
+    return isObservingContentChanges() && !hasVisibleChangeState() && !visibleRendererWasDestroyed(element) && !element.document().quirks().shouldIgnoreContentChange(element);
 }