Changeset 248487 in webkit

Timestamp:

Aug 9, 2019, 4:06:19 PM (6 years ago)

Author:

Wenson Hsieh

Message:

[iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
​https://bugs.webkit.org/show_bug.cgi?id=200591
<rdar://problem/54102238>

Reviewed by Ryosuke Niwa and Tim Horton.

Source/WebKit:

Adopts UIKit SPI to avoid incrementing the general pasteboard's change count whenever an editable element is
focused. This is due to how, in iOS 13, UIKit temporarily writes an image to the pasteboard when showing the
keyboard, to determine whether or not to show the Memojis in the input view.

This causes UIPasteboard's changeCount to increment twice due to adding and then removing the image, which means
that the changeCount sanity checks in the web process will race against the pasteboard gaining and then losing
this temporary image.

Instead, the new -supportsImagePaste SPI may be used to short-circuit this step, and avoid updating the
changeCount when UIKeyboardImpl's delegate changes.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView supportsImagePaste]):

Tools:

Add a new API test to exercise -supportsImagePaste.

• TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/ios/UIKitSPI.h:

Location:

trunk

Files:

• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm (modified) (1 diff)
• Tools/TestWebKitAPI/ios/UIKitSPI.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
+        https://bugs.webkit.org/show_bug.cgi?id=200591
+        <rdar://problem/54102238>
+
+        Reviewed by Ryosuke Niwa and Tim Horton.
+
+        Adopts UIKit SPI to avoid incrementing the general pasteboard's change count whenever an editable element is
+        focused. This is due to how, in iOS 13, UIKit temporarily writes an image to the pasteboard when showing the
+        keyboard, to determine whether or not to show the Memojis in the input view.
+
+        This causes UIPasteboard's changeCount to increment twice due to adding and then removing the image, which means
+        that the changeCount sanity checks in the web process will race against the pasteboard gaining and then losing
+        this temporary image.
+
+        Instead, the new -supportsImagePaste SPI may be used to short-circuit this step, and avoid updating the
+        changeCount when UIKeyboardImpl's delegate changes.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView supportsImagePaste]):
+
 2019-08-09  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -6839 +6839 @@
 }
 
+- (BOOL)supportsImagePaste
+{
+    return mayContainSelectableText(_focusedElementInformation.elementType);
+}
+
 #if HAVE(UI_WK_DOCUMENT_CONTEXT)
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
+        https://bugs.webkit.org/show_bug.cgi?id=200591
+        <rdar://problem/54102238>
+
+        Reviewed by Ryosuke Niwa and Tim Horton.
+
+        Add a new API test to exercise -supportsImagePaste.
+
+        * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
+        (TestWebKitAPI::TEST):
+        * TestWebKitAPI/ios/UIKitSPI.h:
+
 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm

@@ -556 +556 @@
 }
 
+TEST(KeyboardInputTests, SupportsImagePaste)
+{
+    auto inputDelegate = adoptNS([[TestInputDelegate alloc] init]);
+    [inputDelegate setFocusStartsInputSessionPolicyHandler:[&] (WKWebView *, id <_WKFocusedElementInfo>) -> _WKFocusStartsInputSessionPolicy {
+        return _WKFocusStartsInputSessionPolicyAllow;
+    }];
+
+    auto webView = adoptNS([[TestWKWebView alloc] initWithFrame:CGRectMake(0, 0, 320, 568)]);
+    auto contentView = (id <UITextInputPrivate_Staging_54140418>)[webView textInputContentView];
+    [webView synchronouslyLoadHTMLString:@"<input id='input'></input><div contenteditable id='editor'></div><textarea id='textarea'></textarea>"];
+    [webView _setInputDelegate:inputDelegate.get()];
+
+    [webView stringByEvaluatingJavaScript:@"input.focus()"];
+    EXPECT_TRUE(contentView.supportsImagePaste);
+
+    [webView stringByEvaluatingJavaScript:@"document.activeElement.blur(); input.type = 'date'"];
+    [webView waitForNextPresentationUpdate];
+    [webView stringByEvaluatingJavaScript:@"input.focus()"];
+    EXPECT_FALSE(contentView.supportsImagePaste);
+
+    [webView stringByEvaluatingJavaScript:@"editor.focus()"];
+    EXPECT_TRUE(contentView.supportsImagePaste);
+
+    [webView stringByEvaluatingJavaScript:@"document.activeElement.blur(); input.type = 'color'"];
+    [webView waitForNextPresentationUpdate];
+    [webView stringByEvaluatingJavaScript:@"input.focus()"];
+    EXPECT_FALSE(contentView.supportsImagePaste);
+
+    [webView stringByEvaluatingJavaScript:@"textarea.focus()"];
+    EXPECT_TRUE(contentView.supportsImagePaste);
+}
+
 } // namespace TestWebKitAPI
 

trunk/Tools/TestWebKitAPI/ios/UIKitSPI.h

@@ -218 +218 @@
 @end
 
+@protocol UITextInputPrivate_Staging_54140418 <UITextInputPrivate>
+@property (nonatomic, readonly) BOOL supportsImagePaste;
+@end
+
 @interface UIWebFormAccessory (Staging_49666643)
 - (void)setNextPreviousItemsVisible:(BOOL)visible;