Changeset 248539 in webkit

Timestamp:

Aug 12, 2019 12:17:56 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: Elements: Styles: add space between media query and style icon
​https://bugs.webkit.org/show_bug.cgi?id=200623

Reviewed by Joseph Pecoraro.

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):

• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration .header:not(:first-child), .spreadsheet-css-declaration .header:not(.editing-selector) .selector, .spreadsheet-css-declaration.has-icon .header.editing-selector .selector): Added.
(.spreadsheet-css-declaration .header.editing-selector .selector): Deleted.
Ensure the selector field doesn't shift vertically when entering/exiting editing mode.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css (modified) (2 diffs)
• UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Elements: Styles: add space between media query and style icon
+        https://bugs.webkit.org/show_bug.cgi?id=200623
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
+        (WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):
+        * UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
+        (.spreadsheet-css-declaration .header:not(:first-child), .spreadsheet-css-declaration .header:not(.editing-selector) .selector, .spreadsheet-css-declaration.has-icon .header.editing-selector .selector): Added.
+        (.spreadsheet-css-declaration .header.editing-selector .selector): Deleted.
+        Ensure the selector field doesn't shift vertically when entering/exiting editing mode.
+
 2019-08-09  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css

@@ -48 +48 @@
 }
 
-.spreadsheet-css-declaration .header.editing-selector .selector {
+.spreadsheet-css-declaration .header:not(:first-child),
+.spreadsheet-css-declaration .header:not(.editing-selector) .selector,
+.spreadsheet-css-declaration.has-icon .header.editing-selector .selector {
     margin-top: 1px;
 }
@@ -173 +175 @@
     }
 }
+

trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js

@@ -97 +97 @@
             }
             console.assert(iconClassName);
-            this._element.classList.add(iconClassName);
+            this._element.classList.add("has-icon", iconClassName);
         }