Changeset 248550 in webkit

Timestamp:

Aug 12, 2019 3:23:03 PM (5 years ago)

Author:

dino@apple.com

Message:

Contextual menu Hide and Show Link Previews should not have a symbol
​https://bugs.webkit.org/show_bug.cgi?id=200645
<rdar://problem/54129647>

Reviewed by Wenson Hsieh.

Don't use an image on the UIMenuItem.

• UIProcess/API/Cocoa/_WKElementAction.mm:

(+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/_WKElementAction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-12  Dean Jackson  <dino@apple.com>
+
+        Contextual menu Hide and Show Link Previews should not have a symbol
+        https://bugs.webkit.org/show_bug.cgi?id=200645
+        <rdar://problem/54129647>
+
+        Reviewed by Wenson Hsieh.
+
+        Don't use an image on the UIMenuItem.
+
+        * UIProcess/API/Cocoa/_WKElementAction.mm:
+        (+[_WKElementAction imageForElementActionType:]): Return nil for Show/Hide Link Previews.
+
 2019-08-12  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm

@@ -241 +241 @@
         return [UIImage systemImageNamed:@"arrow.down.circle"];
     case _WKElementActionToggleShowLinkPreviews:
-        return [UIImage systemImageNamed:@"safari"];
+        return nil; // Intentionally empty.
     }
 }