Changeset 248587 in webkit

Timestamp:

Aug 12, 2019 8:50:40 PM (5 years ago)

Author:

Devin Rousso

Message:

Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
​https://bugs.webkit.org/show_bug.cgi?id=200639

Reviewed by Joseph Pecoraro.

Since DOM breakpoints revolve around a given DOM node, we attempt to restore DOM breakpoints
whenever new nodes are added by matching them to the path of the DOM breakpoint. When doing
so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly
enable all breakpoints.

• UserInterface/Controllers/DOMDebuggerManager.js:

(WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
(WI.DOMDebuggerManager.prototype._nodeInserted):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/DOMDebuggerManager.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-12  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: REGRESSION: DOMDebugger: breakpoints are forcibly enabled when resolving DOM breakpoints for newly added nodes
+        https://bugs.webkit.org/show_bug.cgi?id=200639
+
+        Reviewed by Joseph Pecoraro.
+
+        Since DOM breakpoints revolve around a given DOM node, we attempt to restore DOM breakpoints
+        whenever new nodes are added by matching them to the path of the DOM breakpoint. When doing
+        so, we should be in a "temporarily restoring breakpoints" mode so that we don't forcibly
+        enable all breakpoints.
+
+        * UserInterface/Controllers/DOMDebuggerManager.js:
+        (WI.DOMDebuggerManager.prototype._speculativelyResolveDOMBreakpointsForURL):
+        (WI.DOMDebuggerManager.prototype._nodeInserted):
+
 2019-08-12  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/DOMDebuggerManager.js

@@ -562 +562 @@
                 }
 
-                if (nodeIdentifier)
-                    this._resolveDOMBreakpoint(breakpoint, nodeIdentifier);
+                if (!nodeIdentifier)
+                    return;
+
+                this._restoringBreakpoints = true;
+                this._resolveDOMBreakpoint(breakpoint, nodeIdentifier);
+                this._restoringBreakpoints = false;
             });
         }
@@ -827 +831 @@
                 continue;
 
+            this._restoringBreakpoints = true;
             this._resolveDOMBreakpoint(breakpoint, node.id);
+            this._restoringBreakpoints = false;
         }
     }