Changeset 248595 in webkit
- Timestamp:
- Aug 13, 2019 8:34:29 AM (5 years ago)
- Location:
- trunk/Source/JavaScriptCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/JavaScriptCore/ChangeLog
r248552 r248595 1 2019-08-13 Joseph Pecoraro <pecoraro@apple.com> 2 3 JSContext Inspector: Basic CommandLineAPI doesn't work 4 https://bugs.webkit.org/show_bug.cgi?id=200659 5 <rdar://problem/54245476> 6 7 Reviewed by Brian Burg. 8 9 * inspector/InjectedScriptSource.js: 10 (BasicCommandLineAPI): 11 Use `method` directly since it already has been setup nicely and doesn't 12 need to be bound. Technically this allows someone to add properties to 13 the CommandLineAPI methods in basic mode (`dir.property = 1`) but that 14 seems harmless. 15 1 16 2019-08-12 Sam Weinig <weinig@apple.com> 2 17 -
trunk/Source/JavaScriptCore/inspector/InjectedScriptSource.js
r248434 r248595 291 291 let value = this._resolveCallArgument(callArgument); 292 292 this._saveResult(value); 293 } catch (e) {}293 } catch { } 294 294 295 295 return this._savedResultIndex; … … 515 515 try { 516 516 remoteObject.description = toStringDescription(value); 517 } catch (e) {}517 } catch { } 518 518 return { 519 519 wasThrown: true, … … 745 745 try { 746 746 isArrayLike = RemoteObject.subtype(object) === "array" && isFinite(object.length) && object.length > 0; 747 } catch (e) {}747 } catch { } 748 748 749 749 for (let o = object; isDefined(o); o = Object.getPrototypeOf(o)) { … … 766 766 if (object.__proto__) 767 767 descriptors.push({name: "__proto__", value: object.__proto__, writable: true, configurable: true, enumerable: false, isOwn: true}); 768 } catch (e) {}768 } catch { } 769 769 770 770 return descriptors; … … 867 867 return this._savedResults[index]; 868 868 } 869 } 869 }; 870 870 871 871 InjectedScript.CollectionMode = { … … 981 981 if (typeof value.splice === "function" && isFinite(value.length)) 982 982 return "array"; 983 } catch (e) {}983 } catch { } 984 984 985 985 return null; … … 1135 1135 if (propertiesThreshold.indexes < 0 || propertiesThreshold.properties < 0) 1136 1136 return preview; 1137 } catch (e){1137 } catch { 1138 1138 preview.lossless = false; 1139 1139 } … … 1387 1387 return string.substr(0, maxLength) + "\u2026"; 1388 1388 } 1389 } 1389 }; 1390 1390 1391 1391 // ------- … … 1399 1399 this.this = RemoteObject.create(callFrame.thisObject, "backtrace"); 1400 1400 this.isTailDeleted = callFrame.isTailDeleted; 1401 } 1401 }; 1402 1402 1403 1403 InjectedScript.CallFrameProxy.prototype = { … … 1412 1412 return scopeChainProxy; 1413 1413 } 1414 } 1414 }; 1415 1415 1416 1416 InjectedScript.CallFrameProxy._scopeTypeNames = { … … 1483 1483 for (let i = 0; i < BasicCommandLineAPI.methods.length; ++i) { 1484 1484 let method = BasicCommandLineAPI.methods[i]; 1485 this[method] = bind(commandLineAPIImpl[method], commandLineAPIImpl); 1486 this[method].toString = function() { return "function " + method + "() { [Command Line API] }" }; 1485 this[method.name] = method; 1487 1486 } 1488 1487 }
Note: See TracChangeset
for help on using the changeset viewer.