Changeset 248673 in webkit

Timestamp:

Aug 14, 2019 10:10:08 AM (5 years ago)

Author:

youenn@apple.com

Message:

Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
​https://bugs.webkit.org/show_bug.cgi?id=200706

Reviewed by Alex Christensen.

Libwebrtc is now soft-linked so we can reenable this test.

• TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:

(-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-14  Youenn Fablet  <youenn@apple.com>
+
+        Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
+        https://bugs.webkit.org/show_bug.cgi?id=200706
+
+        Reviewed by Alex Christensen.
+
+        Libwebrtc is now soft-linked so we can reenable this test.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
+        (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
+
 2019-08-13  Sam Weinig  <weinig@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm

@@ -362 +362 @@
 #endif
 #if HAVE(NETWORK_EXTENSION)
-        // FIXME: Libwebrtc is linking on some configurations to VideoProcessing framework which brings up NetworkExtension framework.
-        // Disable this test until we find a more robust test or libwebrtc weak link VideoProcessing framework.
-        // https://bugs.webkit.org/show_bug.cgi?id=180713
-#if PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED < 101300
         EXPECT_EQ(static_cast<bool>(networkExtensionShouldBeLoaded), static_cast<bool>(networkExtensionLoaded));
-#endif
 #endif // HAVE(NETWORK_EXTENSION)
         isDone = true;