Changeset 248683 in webkit


Ignore:
Timestamp:
Aug 14, 2019 11:45:05 AM (5 years ago)
Author:
Devin Rousso
Message:

Web Inspector: Elements: Computed: move the Box Model section to the top
https://bugs.webkit.org/show_bug.cgi?id=200555

Reviewed by Joseph Pecoraro.

For nodes that use a lot of different CSS properties, having the Box Model section all the
way at the bottom isn't as useful for taking a quick glance at the node's box model data.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.initialLayout):

Location:
trunk/Source/WebInspectorUI
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebInspectorUI/ChangeLog

    r248682 r248683  
     12019-08-14  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: Elements: Computed: move the Box Model section to the top
     4        https://bugs.webkit.org/show_bug.cgi?id=200555
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        For nodes that use a lot of different CSS properties, having the Box Model section all the
     9        way at the bottom isn't as useful for taking a quick glance at the node's box model data.
     10
     11        * UserInterface/Views/ComputedStyleDetailsPanel.js:
     12        (WI.ComputedStyleDetailsPanel.prototype.initialLayout):
     13
    1142019-08-14  Devin Rousso  <drousso@apple.com>
    215
  • trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js

    r248682 r248683  
    8383    initialLayout()
    8484    {
     85        this._boxModelDiagramRow = new WI.BoxModelDetailsSectionRow;
     86
     87        let boxModelGroup = new WI.DetailsSectionGroup([this._boxModelDiagramRow]);
     88        let boxModelSection = new WI.DetailsSection("computed-style-box-model", WI.UIString("Box Model"), [boxModelGroup]);
     89
     90        this.element.appendChild(boxModelSection.element);
     91
    8592        let computedStyleShowAllLabel = document.createElement("label");
    8693        computedStyleShowAllLabel.textContent = WI.UIString("Show All");
     
    126133        this.element.appendChild(this._propertiesSection.element);
    127134        this.element.appendChild(this._variablesSection.element);
    128 
    129         this._boxModelDiagramRow = new WI.BoxModelDetailsSectionRow;
    130 
    131         let boxModelGroup = new WI.DetailsSectionGroup([this._boxModelDiagramRow]);
    132         let boxModelSection = new WI.DetailsSection("computed-style-box-model", WI.UIString("Box Model"), [boxModelGroup]);
    133 
    134         this.element.appendChild(boxModelSection.element);
    135135    }
    136136
Note: See TracChangeset for help on using the changeset viewer.