Changeset 248793 in webkit

Timestamp:

Aug 16, 2019 1:44:37 PM (5 years ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Promise.prototype.finally should accept non-promise objects
​https://bugs.webkit.org/show_bug.cgi?id=200829

Reviewed by Mark Lam.

JSTests:

• stress/promise-finally-should-accept-non-promise-objects.js: Added.

(shouldBe):
(Thenable):
(Thenable.prototype.then):

Source/JavaScriptCore:

According to the Promise.prototype.finally spec step 2[1], we should check @isObject instead of @isPromise,
since Promise.prototype.finally should accept thenable objects that are defined by user libraries (like, bluebird for example).
This patch changes this check to the specified one.

[1]: ​https://tc39.es/proposal-promise-finally/

• builtins/PromisePrototype.js:

(finally):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/promise-finally-should-accept-non-promise-objects.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/builtins/PromisePrototype.js (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2019-08-16  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Promise.prototype.finally should accept non-promise objects
+        https://bugs.webkit.org/show_bug.cgi?id=200829
+
+        Reviewed by Mark Lam.
+
+        * stress/promise-finally-should-accept-non-promise-objects.js: Added.
+        (shouldBe):
+        (Thenable):
+        (Thenable.prototype.then):
+
 2019-08-16  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2019-08-16  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Promise.prototype.finally should accept non-promise objects
+        https://bugs.webkit.org/show_bug.cgi?id=200829
+
+        Reviewed by Mark Lam.
+
+        According to the Promise.prototype.finally spec step 2[1], we should check @isObject instead of @isPromise,
+        since Promise.prototype.finally should accept thenable objects that are defined by user libraries (like, bluebird for example).
+        This patch changes this check to the specified one.
+
+        [1]: https://tc39.es/proposal-promise-finally/
+
+        * builtins/PromisePrototype.js:
+        (finally):
+
 2019-08-16  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/builtins/PromisePrototype.js

@@ -69 +69 @@
     "use strict";
 
-    if (!@isPromise(this))
-        @throwTypeError("|this| is not a Promise");
+    if (!@isObject(this))
+        @throwTypeError("|this| is not a object");
 
     const constructor = @speciesConstructor(this, @Promise);