Changeset 248889 in webkit

Timestamp:

Aug 19, 2019 9:10:39 PM (5 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: RTL: Network headers values should be preserved
​https://bugs.webkit.org/show_bug.cgi?id=200873

Reviewed by Joseph Pecoraro.

Replace spans with bdi elements, which have unicode-bidi: isolate User Agent style.
This works well with both LTR and RTL values.

• UserInterface/Views/ResourceDetailsSection.js:

(WI.ResourceDetailsSection.prototype.appendKeyValuePair):
Drive-by: remove unnecessary if/else statement and use append instead.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/ResourceDetailsSection.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-08-19  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: RTL: Network headers values should be preserved
+        https://bugs.webkit.org/show_bug.cgi?id=200873
+
+        Reviewed by Joseph Pecoraro.
+
+        Replace spans with bdi elements, which have `unicode-bidi: isolate` User Agent style.
+        This works well with both LTR and RTL values.
+
+        * UserInterface/Views/ResourceDetailsSection.js:
+        (WI.ResourceDetailsSection.prototype.appendKeyValuePair):
+        Drive-by: remove unnecessary if/else statement and use `append` instead.
+
 2019-08-19  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/ResourceDetailsSection.js

@@ -95 +95 @@
             keyElement.textContent = key + (value ? ": " : "");
 
-            let valueElement = p.appendChild(document.createElement("span"));
+            let valueElement = p.appendChild(document.createElement("bdi"));
             valueElement.className = "value";
-            if (value instanceof Node)
-                valueElement.appendChild(value);
-            else
-                valueElement.textContent = value;
+            valueElement.append(value || "");
         }