Changeset 248975 in webkit

Timestamp:

Aug 21, 2019 4:51:34 PM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Fix capitalization in Found x new Test failure message
​https://bugs.webkit.org/show_bug.cgi?id=201004

Reviewed by Alexey Proskuryakov.

• BuildSlaveSupport/ews-build/steps.py:

(AnalyzeLayoutTestsResults.report_failure):
(AnalyzeAPITestsResults.analyzeResults):

• BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.

Location:

trunk/Tools

Files:

• BuildSlaveSupport/ews-build/steps.py (modified) (2 diffs)
• BuildSlaveSupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/ews-build/steps.py

@@ -1066 +1066 @@
         pluralSuffix = 's' if len(new_failures) > 1 else ''
         new_failures_string = ', '.join([failure_name for failure_name in new_failures])
-        message = 'Found {} new Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
+        message = 'Found {} new test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
         self.descriptionDone = message
         self.build.buildFinished([message], FAILURE)
@@ -1387 +1387 @@
             self.build.results = FAILURE
             pluralSuffix = 's' if len(new_failures) > 1 else ''
-            message = 'Found {} new API Test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
+            message = 'Found {} new API test failure{}: {}'.format(len(new_failures), pluralSuffix, new_failures_string)
             self.descriptionDone = message
             self.build.buildFinished([message], FAILURE)

trunk/Tools/BuildSlaveSupport/ews-build/steps_unittest.py

@@ -1268 +1268 @@
         self.setProperty('first_run_failures', ["jquery/offset.html"])
         self.setProperty('second_run_failures', ["jquery/offset.html"])
-        self.expectOutcome(result=FAILURE, state_string='Found 1 new Test failure: jquery/offset.html (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: jquery/offset.html (failure)')
         return self.runStep()
 
@@ -1283 +1283 @@
         self.setProperty('first_run_failures', ['test1', 'test2'])
         self.setProperty('second_run_failures', ['test1'])
-        self.expectOutcome(result=FAILURE, state_string='Found 1 new Test failure: test1 (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 1 new test failure: test1 (failure)')
         return self.runStep()
 
@@ -1351 +1351 @@
         self.setProperty('second_run_failures', ['test{}'.format(i) for i in range(0, 30)])
         self.setProperty('clean_tree_run_failures', ['test{}'.format(i) for i in range(0, 10)])
-        self.expectOutcome(result=FAILURE, state_string='Found 30 new Test failures: test1, test0, test3, test2, test5, test4, test7, test6, test9, test8, test24, test25, test26, test27, test20, test21, test22, test23, test28, test29, test19, test18, test11, test10, test13, test12, test15, test14, test17, test16 (failure)')
+        self.expectOutcome(result=FAILURE, state_string='Found 30 new test failures: test1, test0, test3, test2, test5, test4, test7, test6, test9, test8, test24, test25, test26, test27, test20, test21, test22, test23, test28, test29, test19, test18, test11, test10, test13, test12, test15, test14, test17, test16 (failure)')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-21  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Fix capitalization in Found x new Test failure message
+        https://bugs.webkit.org/show_bug.cgi?id=201004
+
+        Reviewed by Alexey Proskuryakov.
+
+        * BuildSlaveSupport/ews-build/steps.py:
+        (AnalyzeLayoutTestsResults.report_failure):
+        (AnalyzeAPITestsResults.analyzeResults):
+        * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
+
 2019-08-21  Aakash Jain  <aakash_jain@apple.com>