Changeset 248995 in webkit

Timestamp:

Aug 21, 2019 10:33:33 PM (5 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Fix drawer style
​https://bugs.webkit.org/show_bug.cgi?id=200988

Rubber-stamped by Aakash Jain.

• resultsdbpy/resultsdbpy/view/static/js/drawer.js:

(Drawer): Nothing in the drawer should be selectable.
(ConfigurationSelectors): Standardize text size, remove underscore from expanders.

• resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:

(.action:hover): Disable underline on 'links' which are actually actions
(.unselectable): Make a div unselectable.

• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:

(Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/drawer.js (modified) (3 diffs)
• resultsdbpy/resultsdbpy/view/static/library/css/webkit.css (modified) (2 diffs)
• resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-08-21  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Fix drawer style
+        https://bugs.webkit.org/show_bug.cgi?id=200988
+
+        Rubber-stamped by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
+        (Drawer): Nothing in the drawer should be selectable.
+        (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
+        * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
+        (.action:hover): Disable underline on 'links' which are actually actions
+        (.unselectable): Make a div unselectable.
+        * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
+        (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
+
 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js

@@ -60 +60 @@
     });
 
-    return `<div class="drawer left under-topbar-with-actions" ref="${drawerRef}">
+    return `<div class="drawer left under-topbar-with-actions unselectable" ref="${drawerRef}">
             ${controls.map(control => {
                 return `<div class="list">
@@ -227 +227 @@
                 });
 
-                DOM.inject(element, `<a style="cursor: pointer;" class="text medium" ref="${expander}">+</a>
+                DOM.inject(element, `<a class="link-button text medium" ref="${expander}">+</a>
                     ${details.name} <br>
                     ${options.map(option => {
@@ -276 +276 @@
         });
 
-        return `<div ref="${ref}"></div>`;
+        return `<div style="font-size: var(--smallSize);" ref="${ref}"></div>`;
     }).join('')
 }

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/css/webkit.css

@@ -195 +195 @@
 }
 
+.link-button:hover {
+  text-decoration: none;
+  cursor: pointer;
+}
+
 .divider, hr {
   margin-block-start: 0.5em;
@@ -2556 +2561 @@
   background: var(--orange);
 }
+
+.unselectable {
+  -webkit-touch-callout: none;
+  -webkit-user-select: none;
+  user-select: none;
+}

trunk/Tools/resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js

@@ -536 +536 @@
     }));
     return {
-        header: Timeline.ExpandableHeaderComponent(`<a href="javascript:void(0)" ref="${ref}">+</a>` + mainLabel, subLabels, composer),
+        header: Timeline.ExpandableHeaderComponent(`<a class="link-button" href="javascript:void(0)" ref="${ref}">+</a>` + mainLabel, subLabels, composer),
         series: Timeline.ExpandableSeriesComponent(mainSeries, subSerieses, composer),
     }