Changeset 249027 in webkit

Timestamp:

Aug 22, 2019 2:28:29 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Logging in FileSystem::deleteFile should avoid logging unsurprising errors
​https://bugs.webkit.org/show_bug.cgi?id=200831

Patch by Kate Cheney <Kate Cheney> on 2019-08-22
Reviewed by Chris Dumez.

To avoid overlogging unnecessary information, added a check to avoid logging
ENOENT (file not found) errors.

• wtf/posix/FileSystemPOSIX.cpp:

(WTF::FileSystemImpl::deleteFile):

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/posix/FileSystemPOSIX.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-08-22  Kate Cheney  <katherine_cheney@apple.com>
+
+        Logging in FileSystem::deleteFile should avoid logging unsurprising errors
+        https://bugs.webkit.org/show_bug.cgi?id=200831
+
+        Reviewed by Chris Dumez.
+
+        To avoid overlogging unnecessary information, added a check to avoid logging
+        ENOENT (file not found) errors.
+
+        * wtf/posix/FileSystemPOSIX.cpp:
+        (WTF::FileSystemImpl::deleteFile):
+
 2019-08-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/posix/FileSystemPOSIX.cpp

@@ -74 +74 @@
     // unlink(...) returns 0 on successful deletion of the path and non-zero in any other case (including invalid permissions or non-existent file)
     bool unlinked = !unlink(fsRep.data());
-    if (!unlinked)
+    if (!unlinked && errno != ENOENT)
         LOG_ERROR("File failed to delete. Error message: %s", strerror(errno));