Changeset 249122 in webkit

Timestamp:

Aug 26, 2019 4:01:47 PM (5 years ago)

Author:

Devin Rousso

Message:

Unreviewed, fix test failure after r200971

• inspector/timeline/line-column-expected.txt:

• inspector/debugger/tail-deleted-frames-this-value.html:

Add messages to all InspectorTest.assert so we can know which one is firing on the bots.

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/debugger/tail-deleted-frames-this-value.html (modified) (2 diffs)
• inspector/timeline/line-column-expected.txt (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-26  Devin Rousso  <drousso@apple.com>
+
+        Unreviewed, fix test failure after r200971
+
+        * inspector/timeline/line-column-expected.txt:
+
+        * inspector/debugger/tail-deleted-frames-this-value.html:
+        Add messages to all `InspectorTest.assert` so we can know which one is firing on the bots.
+
 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html

@@ -43 +43 @@
         let callFrames = targetData.callFrames;
 
-        InspectorTest.assert(callFrames.length >= expectedFrames.length);
+        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
 
         // Resolve a thisObject preview on each of the CallFrames.
@@ -61 +61 @@
                 let expectedFrame = expectedFrames[i];
                 InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
-                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName);
-                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted);
+                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
+                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
 
                 let thisObject = callFrame.thisObject;
                 let properties = thisObject.preview.propertyPreviews;
-                InspectorTest.assert(properties.length === 1);
+                InspectorTest.assert(properties.length === 1, "Should hvae one property.");
                 let prop = properties[0];
                 InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);

trunk/LayoutTests/inspector/timeline/line-column-expected.txt

@@ -46 +46 @@
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }
@@ -108 +108 @@
               "url": "",
               "scriptId": "<filtered>",
-              "lineNumber": 141,
+              "lineNumber": 144,
               "columnNumber": 97
             }
@@ -161 +161 @@
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }
@@ -221 +221 @@
           "url": "",
           "scriptId": "<filtered>",
-          "lineNumber": 141,
+          "lineNumber": 144,
           "columnNumber": 97
         }