Changeset 249127 in webkit

Timestamp:

Aug 26, 2019 5:48:14 PM (5 years ago)

Author:

Devin Rousso

Message:

Unreviewed, add extra test failure logging after r200971

• inspector/debugger/tail-deleted-frames-this-value.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• inspector/debugger/tail-deleted-frames-this-value.html (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-26  Devin Rousso  <drousso@apple.com>
+
+        Unreviewed, add extra test failure logging after r200971
+
+        * inspector/debugger/tail-deleted-frames-this-value.html:
+        Also log the actual value (in addition to the expected one) in assertion messages.
+
 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/inspector/debugger/tail-deleted-frames-this-value.html

@@ -43 +43 @@
         let callFrames = targetData.callFrames;
 
-        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have ${expectedFrames.length} frames.`);
+        InspectorTest.assert(callFrames.length >= expectedFrames.length, `Should have at least ${expectedFrames.length} frames, but have ${callFrame.length} instead.`);
 
         // Resolve a thisObject preview on each of the CallFrames.
@@ -61 +61 @@
                 let expectedFrame = expectedFrames[i];
                 InspectorTest.log("Expected frame: " + JSON.stringify(expectedFrame));
-                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}'.`);
-                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}.`);
+                InspectorTest.assert(callFrame.functionName === expectedFrame.functionName, `Should have functionName of '${expectedFrame.functionName}', but have '${callFrame.functionName}' instead.`);
+                InspectorTest.assert(callFrame.isTailDeleted === expectedFrame.isTailDeleted, `Should have isTailDeleted of '${expectedFrame.isTailDeleted}', but have '${callFrame.isTailDeleted}' instead.`);
 
                 let thisObject = callFrame.thisObject;
                 let properties = thisObject.preview.propertyPreviews;
-                InspectorTest.assert(properties.length === 1, "Should hvae one property.");
+                InspectorTest.assert(properties.length === 1, "Should have one property.");
                 let prop = properties[0];
                 InspectorTest.expectThat(expectedFrame.thisValue[0] === prop.name, `'this' value should have expected property: ${expectedFrame.thisValue[0]}`);