Changeset 249174 in webkit


Ignore:
Timestamp:
Aug 27, 2019 2:42:32 PM (5 years ago)
Author:
Megan Gardner
Message:

Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed.html
​https://bugs.webkit.org/show_bug.cgi?id=201163
<rdar://problem/54727027>

Reviewed by Simon Fraser.

Altering test slightly to have a reasonable test expecation on iPad.

  • platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt: Added.
Location:
trunk/LayoutTests
Files:
1 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r249173 r249174  
     12019-08-27  Megan Gardner  <megan_gardner@apple.com>
     2
     3        Update Test Expectations for iPad for fast/scrolling/ios/autoscroll-input-when-very-zoomed.html
     4        https://bugs.webkit.org/show_bug.cgi?id=201163
     5        <rdar://problem/54727027>
     6
     7        Reviewed by Simon Fraser.
     8
     9        Altering test slightly to have a reasonable test expecation on iPad.
     10
     11        * platform/ipad/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt: Added.
     12
    1132019-08-27  Devin Rousso  <drousso@apple.com>
    214

  • trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed-expected.txt

    r248977 r249174  
    1 This test focuses a form, them zooms and scrolls the page. Then text is entered in the form, and we check to make sure the page has scrolled so that the input is visible again, but not more that once, as it should be visible after the first scroll.
    2 PASS: page has scrolled when the selection is not visible, and not scrolled when the selection is already visible.
     1This test focuses a form, them zooms and scrolls the page. Then text is entered in the form, and we check to make sure the page has scrolled when needed to make the input visible again. On iPhone, the page should scroll on the first text input so that the input element in is visible again, but should not scroll more than once, as it should be visible after the first scroll. On iPad, the input should not scroll at all, as the iPad is larger and should not need to scroll for the input element to be visible. The test results should refelct these expectaitions.
     2Page has scrolled on the first input
     3Page has not scrolled on the second input
    34

  • trunk/LayoutTests/fast/scrolling/ios/autoscroll-input-when-very-zoomed.html

    r249042 r249174  
    2323
    2424        await UIHelper.immediateZoomToScale(3.284);
    25         await UIHelper.immediateScrollTo(390, 390);
     25        await UIHelper.immediateScrollTo(390, 500);
    2626
    2727        await Promise.all([UIHelper.ensureVisibleContentRectUpdate(), UIHelper.ensureStablePresentationUpdate()]);
    … …  
    4242        var finalYOffset = window.pageYOffset;
    4343
    44         if ((originalXOffset != secondXOffset) && (secondXOffset == finalXOffset) && (originalYOffset != secondYOffset) && (secondYOffset == finalYOffset))
    45              output += 'PASS: page has scrolled when the selection is not visible, and not scrolled when the selection is already visible.';
    46         else {
    47             if ((originalXOffset == secondXOffset) || (originalYOffset == secondYOffset))
    48                 output += 'FAIL: page has failed to scrolled on the first input<br>';
    49             if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
    50                 output += 'FAIL: page has scrolled on the second input';
    51         }
     44        if ((originalXOffset != secondXOffset) || (originalYOffset != secondYOffset))
     45            output += 'Page has scrolled on the first input';
     46        if ((originalXOffset == secondXOffset) && (originalYOffset == secondYOffset))
     47            output += 'Page has not scrolled on the first input';
     48        output +='<br>';
     49
     50        if ((secondXOffset != finalXOffset) || (secondYOffset != finalYOffset))
     51             output += 'Page has scrolled on the second input.';
     52        if ((secondXOffset == finalXOffset) && (secondYOffset == finalYOffset))
     53            output += 'Page has not scrolled on the second input';
    5254        output += '<br>';
    5355
    … …  
    7981This test focuses a form, them zooms and scrolls the page.
    8082Then text is entered in the form, and we check to make sure the page has scrolled
    81 so that the input is visible again, but not more that once, as it should be visible
    82 after the first scroll.
     83when needed to make the input visible again. On iPhone, the page should scroll on
     84the first text input so that the input element in is visible again, but should not
     85scroll more than once, as it should be visible after the first scroll. On iPad, the
     86input should not scroll at all, as the iPad is larger and should not need to scroll
     87for the input element to be visible. The test results should refelct these expectaitions.
    8388<div id="testArea"><input id="editable" type="text" value="Test text"></input></div>
    8489</body>
Note: See TracChangeset for help on using the changeset viewer.