Changeset 249296 in webkit

Timestamp:

Aug 29, 2019 3:17:46 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[iOS 13] Caret does not appear in text field if the body element is translated completely out of the viewport
​https://bugs.webkit.org/show_bug.cgi?id=201287
<rdar://problem/54780864>

Reviewed by Tim Horton.

Source/WebKit:

During EditorState computation, we use the hidden editable element heuristic to determine whether we should
begin suppressing selection gestures and UI. Currently, we use the editable root of the selection range to
determine where in the layer tree we should start our ascent, in search of a completely transparent or
completely clipped container.

However, in the case where the selection is inside a focused text field, this causes us to walk up the layer
tree starting at the RenderLayer corresponding to the text field's inner contenteditable div, which is different
than the text field's enclosing RenderLayer in the case where the containing block is transformed, such that no
part of it is within the visible viewport. This scenario is exercised by the below test case, in which the caret
after transforming the body horizontally by -100vw is hidden due to a false positive in the hidden editable area
heuristic.

Fix this by starting the layer tree ascent from the enclosing layer of the text form control if applicable,
instead of the inner editable area under the shadow root of the form control.

Test: editing/selection/ios/show-selection-in-transformed-container.html

• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

LayoutTests:

Add a new layout test that covers this scenario. See WebKit ChangeLog for additional detail.

• editing/selection/ios/show-selection-in-transformed-container-expected.txt: Added.
• editing/selection/ios/show-selection-in-transformed-container.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/ios/show-selection-in-transformed-container-expected.txt (added)
• LayoutTests/editing/selection/ios/show-selection-in-transformed-container.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-08-29  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS 13] Caret does not appear in text field if the body element is translated completely out of the viewport
+        https://bugs.webkit.org/show_bug.cgi?id=201287
+        <rdar://problem/54780864>
+
+        Reviewed by Tim Horton.
+
+        Add a new layout test that covers this scenario. See WebKit ChangeLog for additional detail.
+
+        * editing/selection/ios/show-selection-in-transformed-container-expected.txt: Added.
+        * editing/selection/ios/show-selection-in-transformed-container.html: Added.
+
 2019-08-29  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-08-29  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [iOS 13] Caret does not appear in text field if the body element is translated completely out of the viewport
+        https://bugs.webkit.org/show_bug.cgi?id=201287
+        <rdar://problem/54780864>
+
+        Reviewed by Tim Horton.
+
+        During EditorState computation, we use the hidden editable element heuristic to determine whether we should
+        begin suppressing selection gestures and UI. Currently, we use the editable root of the selection range to
+        determine where in the layer tree we should start our ascent, in search of a completely transparent or
+        completely clipped container.
+
+        However, in the case where the selection is inside a focused text field, this causes us to walk up the layer
+        tree starting at the RenderLayer corresponding to the text field's inner contenteditable div, which is different
+        than the text field's enclosing RenderLayer in the case where the containing block is transformed, such that no
+        part of it is within the visible viewport. This scenario is exercised by the below test case, in which the caret
+        after transforming the body horizontally by -100vw is hidden due to a false positive in the hidden editable area
+        heuristic.
+
+        Fix this by starting the layer tree ascent from the enclosing layer of the text form control if applicable,
+        instead of the inner editable area under the shadow root of the form control.
+
+        Test: editing/selection/ios/show-selection-in-transformed-container.html
+
+        * WebProcess/WebPage/ios/WebPageIOS.mm:
+        (WebKit::WebPage::platformEditorState const):
+
 2019-08-29  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm

@@ -274 +274 @@
         }
         if (result.isContentEditable) {
-            if (auto container = makeRefPtr(selection.rootEditableElement()))
-                postLayoutData.editableRootIsTransparentOrFullyClipped = isTransparentOrFullyClipped(*container);
+            if (auto editableRootOrFormControl = makeRefPtr(selection.rootEditableElement())) {
+                if (is<HTMLTextFormControlElement>(editableRootOrFormControl->shadowHost()))
+                    editableRootOrFormControl = editableRootOrFormControl->shadowHost();
+                postLayoutData.editableRootIsTransparentOrFullyClipped = isTransparentOrFullyClipped(*editableRootOrFormControl);
+            }
         }
         computeEditableRootHasContentAndPlainText(selection, postLayoutData);