Changeset 249432 in webkit

Timestamp:

Sep 3, 2019 11:06:58 AM (5 years ago)

Author:

Jonathan Bedard

Message:

results.webkit.org: Increase default limit for LimitSlider
​https://bugs.webkit.org/show_bug.cgi?id=201424

Reviewed by Aakash Jain.

• resultsdbpy/resultsdbpy/view/static/js/drawer.js:

(LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• resultsdbpy/resultsdbpy/view/static/js/drawer.js (modified) (3 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2019-09-03  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Increase default limit for LimitSlider
+        https://bugs.webkit.org/show_bug.cgi?id=201424
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
+        (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
+
 2019-09-03  Antoine Quint  <graouts@apple.com>
 

trunk/Tools/resultsdbpy/resultsdbpy/view/static/js/drawer.js

@@ -167 +167 @@
 }
 
-function LimitSlider(callback, max = 1000, defaultValue = 100) {
-    const maxRange = 1000;
-    const scale = (Math.log(max) - Math.log(1)) / maxRange;
+function LimitSlider(callback, max = 10000, defaultValue = 1000) {
     const limitModifier = new QueryModifier('limit');
     const startingValue = limitModifier.current().length ? limitModifier.current()[limitModifier.current().length -1]:defaultValue;
@@ -191 +189 @@
         onElementMount: (element) => {
             element.oninput = () => {
-                const newLimit = Math.ceil(Math.exp(Math.log(1) + scale * element.value));
+                const newLimit = Math.ceil(element.value);
                 limitModifier.replace(newLimit);
                 numberRef.setState(newLimit);
@@ -197 +195 @@
             }
         },
-        onStateUpdate: (element, state) => {element.value = (Math.log(state) - Math.log(1)) / scale;}
+        onStateUpdate: (element, state) => {element.value = state;}
     });
     return `<div class="input">
             <label style="color:var(--boldInverseColor)">Limit:</label>
-            <input type="range" min="0" max="${maxRange}" ref="${sliderRef}" style="background:var(--boldInverseColor)"></input>
+            <input type="range" min="0" max="${max}" ref="${sliderRef}" style="background:var(--boldInverseColor)"></input>
             <input type="number" min="1" ref="${numberRef}" pattern="^[0-9]"></input>
         </div>`