Changeset 249480 in webkit
- Timestamp:
- Sep 4, 2019 8:19:11 AM (5 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r249478 r249480 1 2019-09-04 Rob Buis <rbuis@igalia.com> 2 3 Allow checking whether image was created from JavaScript 4 https://bugs.webkit.org/show_bug.cgi?id=200662 5 6 Reviewed by Darin Adler. 7 8 No behavior change. 9 10 * html/HTMLImageElement.cpp: 11 (WebCore::HTMLImageElement::HTMLImageElement): 12 (WebCore::HTMLImageElement::create): 13 * html/HTMLImageElement.h: 14 (WebCore::HTMLImageElement::createdByParser const): 15 * html/HTMLTagNames.in: 16 1 17 2019-09-04 Zan Dobersek <zdobersek@igalia.com> 2 18 -
trunk/Source/WebCore/html/HTMLImageElement.cpp
r249194 r249480 69 69 using namespace HTMLNames; 70 70 71 HTMLImageElement::HTMLImageElement(const QualifiedName& tagName, Document& document, HTMLFormElement* form )71 HTMLImageElement::HTMLImageElement(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser) 72 72 : HTMLElement(tagName, document) 73 73 , m_imageLoader(*this) … … 77 77 , m_imageDevicePixelRatio(1.0f) 78 78 , m_experimentalImageMenuEnabled(false) 79 , m_createdByParser(createdByParser) 79 80 { 80 81 ASSERT(hasTagName(imgTag)); … … 87 88 } 88 89 89 Ref<HTMLImageElement> HTMLImageElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form )90 { 91 return adoptRef(*new HTMLImageElement(tagName, document, form ));90 Ref<HTMLImageElement> HTMLImageElement::create(const QualifiedName& tagName, Document& document, HTMLFormElement* form, bool createdByParser) 91 { 92 return adoptRef(*new HTMLImageElement(tagName, document, form, createdByParser)); 92 93 } 93 94 -
trunk/Source/WebCore/html/HTMLImageElement.h
r249194 r249480 45 45 public: 46 46 static Ref<HTMLImageElement> create(Document&); 47 static Ref<HTMLImageElement> create(const QualifiedName&, Document&, HTMLFormElement* );47 static Ref<HTMLImageElement> create(const QualifiedName&, Document&, HTMLFormElement* = nullptr, bool createdByParser = false); 48 48 static Ref<HTMLImageElement> createForJSConstructor(Document&, Optional<unsigned> width, Optional<unsigned> height); 49 49 … … 124 124 void defaultEventHandler(Event&) final; 125 125 126 bool createdByParser() const { return m_createdByParser; } 127 126 128 protected: 127 HTMLImageElement(const QualifiedName&, Document&, HTMLFormElement* = 0);129 HTMLImageElement(const QualifiedName&, Document&, HTMLFormElement* = nullptr, bool createdByParser = false); 128 130 129 131 void didMoveToNewDocument(Document& oldDocument, Document& newDocument) override; … … 186 188 bool m_experimentalImageMenuEnabled; 187 189 bool m_hadNameBeforeAttributeChanged { false }; // FIXME: We only need this because parseAttribute() can't see the old value. 190 bool m_createdByParser { false }; 188 191 189 192 RefPtr<EditableImageReference> m_editableImage; -
trunk/Source/WebCore/html/HTMLTagNames.in
r248960 r249480 69 69 iframe interfaceName=HTMLIFrameElement 70 70 image interfaceName=HTMLUnknownElement 71 img interfaceName=HTMLImageElement, constructorNeedsFormElement 71 img interfaceName=HTMLImageElement, constructorNeedsFormElement, constructorNeedsCreatedByParser 72 72 input constructorNeedsFormElement, constructorNeedsCreatedByParser 73 73 ins interfaceName=HTMLModElement
Note: See TracChangeset
for help on using the changeset viewer.