Changeset 249493 in webkit

Timestamp:

Sep 4, 2019 12:38:37 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[iPadOS] Unable to change sheets on Airtable.com
​https://bugs.webkit.org/show_bug.cgi?id=201456
<rdar://problem/51557377>

Patch by Antoine Quint <Antoine Quint> on 2019-09-04
Reviewed by Dean Jackson.

Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.

• page/Quirks.cpp:

(WebCore::Quirks::simulatedMouseEventTypeForTarget const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-04  Antoine Quint  <graouts@apple.com>
+
+        [iPadOS] Unable to change sheets on Airtable.com
+        https://bugs.webkit.org/show_bug.cgi?id=201456
+        <rdar://problem/51557377>
+
+        Reviewed by Dean Jackson.
+
+        Simulated mouse events are required to be able to manipulate cells and and columns on Airtable.com. However, dispatching a "mousedown" event on
+        tabs allowing to pick a different sheet ends up calling preventDefault() and prevent "click" events from being dispatched, which makes it
+        impossible to change sheet. We now limit the dispatch of simulated mouse events to the grid.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::simulatedMouseEventTypeForTarget const):
+
 2019-09-04  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -377 +377 @@
         return Event::IsCancelable::No;
 
+    if (equalLettersIgnoringASCIICase(host, "airtable.com") || host.endsWithIgnoringASCIICase(".airtable.com")) {
+        // We want to limit simulated mouse events to elements under <div id="paneContainer"> to allow for column re-ordering and multiple cell selection.
+        if (is<Node>(target)) {
+            auto* node = downcast<Node>(target);
+            if (auto* paneContainer = node->treeScope().getElementById(AtomString("paneContainer"))) {
+                if (paneContainer->contains(node))
+                    return Event::IsCancelable::Yes;
+            }
+        }
+        return { };
+    }
+
     return Event::IsCancelable::Yes;
 }