Changeset 249524 in webkit


Ignore:
Timestamp:
Sep 4, 2019 11:02:53 PM (5 years ago)
Author:
Fujii Hironori
Message:

[Win][Clang] InspectorNetworkAgent.cpp(1122,20): error: cannot decompose this type; 'std::tuple_size<const WTF::KeyValuePair<WTF::String, WTF::RefPtr<WTF::JSONImpl::Value, WTF::DumbPtrTraits<WTF::JSONImpl::Value> > >>::value' is not a valid integral const
https://bugs.webkit.org/show_bug.cgi?id=201489

Unreviewed build fix for clang-cl.

clang-cl 8 can't use a structured binding for a const struct.

No behavior change.

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::interceptWithResponse): Not to use a structured binding for a const struct.

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r249519 r249524  
     12019-09-04  Fujii Hironori  <Hironori.Fujii@sony.com>
     2
     3        [Win][Clang] InspectorNetworkAgent.cpp(1122,20): error: cannot decompose this type; 'std::tuple_size<const WTF::KeyValuePair<WTF::String, WTF::RefPtr<WTF::JSONImpl::Value, WTF::DumbPtrTraits<WTF::JSONImpl::Value> > >>::value' is not a valid integral const
     4        https://bugs.webkit.org/show_bug.cgi?id=201489
     5
     6        Unreviewed build fix for clang-cl.
     7
     8        clang-cl 8 can't use a structured binding for a const struct.
     9
     10        No behavior change.
     11
     12        * inspector/agents/InspectorNetworkAgent.cpp:
     13        (WebCore::InspectorNetworkAgent::interceptWithResponse): Not to use a structured binding for a const struct.
     14
    1152019-09-04  Chris Dumez  <cdumez@apple.com>
    216
  • trunk/Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp

    r249504 r249524  
    11201120    if (headers) {
    11211121        HTTPHeaderMap explicitHeaders;
    1122         for (auto& [key, value] : *headers) {
     1122        for (auto& header : *headers) {
    11231123            String headerValue;
    1124             if (value->asString(headerValue))
    1125                 explicitHeaders.add(key, headerValue);
     1124            if (header.value->asString(headerValue))
     1125                explicitHeaders.add(header.key, headerValue);
    11261126        }
    11271127        overrideResponse.setHTTPHeaderFields(WTFMove(explicitHeaders));
Note: See TracChangeset for help on using the changeset viewer.