Changeset 249534 in webkit

Timestamp:

Sep 5, 2019 10:27:14 AM (5 years ago)

Author:

Chris Fleizach

Message:

AX: children cache are not re-computed if tab index is removed
​https://bugs.webkit.org/show_bug.cgi?id=201502

Reviewed by Zalan Bujtas.

Source/WebCore:

Test: accessibility/tabindex-removed.html

If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
information can be stale and lead to incorrect navigation with VoiceOver.

• accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::handleAttributeChange):

LayoutTests:

• accessibility/tabindex-removed-expected.txt: Added.
• accessibility/tabindex-removed.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/tabindex-removed-expected.txt (added)
• LayoutTests/accessibility/tabindex-removed.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AXObjectCache.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-09-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: children cache are not re-computed if tab index is removed
+        https://bugs.webkit.org/show_bug.cgi?id=201502
+
+        Reviewed by Zalan Bujtas.
+
+        * accessibility/tabindex-removed-expected.txt: Added.
+        * accessibility/tabindex-removed.html: Added.
+
 2019-09-04  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-05  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: children cache are not re-computed if tab index is removed
+        https://bugs.webkit.org/show_bug.cgi?id=201502
+
+        Reviewed by Zalan Bujtas.
+
+        Test: accessibility/tabindex-removed.html
+
+        If the tabindex changes, it can potentially affect whether an element is accessible. If we don't update the children cache
+        information can be stale and lead to incorrect navigation with VoiceOver.
+
+        * accessibility/AXObjectCache.cpp:
+        (WebCore::AXObjectCache::handleAttributeChange):
+
 2019-09-05  Konstantin Tokarev  <annulen@yandex.ru>
 

trunk/Source/WebCore/accessibility/AXObjectCache.cpp

@@ -1497 +1497 @@
     else if (attrName == forAttr && is<HTMLLabelElement>(*element))
         labelChanged(element);
+    else if (attrName == tabindexAttr)
+        childrenChanged(element->parentNode(), element);
 
     if (!attrName.localName().string().startsWith("aria-"))