Changeset 249600 in webkit
- Timestamp:
- Sep 6, 2019 5:08:13 PM (5 years ago)
- Location:
- trunk/Source/WebKit
- Files:
-
- 4 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebKit/ChangeLog
r249589 r249600 1 2019-09-06 Jiewen Tan <jiewen_tan@apple.com> 2 3 [WebAuthn] Make WebAuthn default off and let clients turn it on at will 4 https://bugs.webkit.org/show_bug.cgi?id=201439 5 <rdar://problem/54998154> 6 7 Reviewed by Youenn Fablet. 8 9 This patch makes WebAuthn default off such that clients that have the right entitlements 10 could turn it on and we don't risk at turning on a Web API that does nothing by default. 11 12 This patch doesn't add any SPI to turn the feature on as it is currently doable via 13 - [WKPreferencesPrivate _setEnabled:forExperimentalFeature:]. 14 15 * Shared/WebPreferences.yaml: 16 * Shared/WebPreferencesDefaultValues.cpp: 17 (WebKit::defaultWebAuthenticationEnabled): Deleted. 18 * Shared/WebPreferencesDefaultValues.h: 19 1 20 2019-09-06 Alex Christensen <achristensen@webkit.org> 2 21 -
trunk/Source/WebKit/Shared/WebPreferences.yaml
r249512 r249600 768 768 WebAuthenticationEnabled: 769 769 type: bool 770 defaultValue: defaultWebAuthenticationEnabled()770 defaultValue: false 771 771 humanReadableName: "Web Authentication" 772 772 humanReadableDescription: "Enable Web Authentication support" -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp
r249512 r249600 65 65 #endif // ENABLE(TEXT_AUTOSIZING) && !PLATFORM(IOS_FAMILY) 66 66 67 bool defaultWebAuthenticationEnabled()68 {69 #if PLATFORM(IOS_FAMILY)70 return WebCore::IOSApplication::isMobileSafari() || WebCore::IOSApplication::isSafariViewService();71 #elif PLATFORM(MAC)72 return true;73 #else74 return false;75 #endif76 }77 78 67 } // namespace WebKit -
trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h
r249512 r249600 286 286 #endif 287 287 288 bool defaultWebAuthenticationEnabled();289 290 288 } // namespace WebKit
Note: See TracChangeset
for help on using the changeset viewer.