Changeset 249628 in webkit

Timestamp:

Sep 7, 2019 10:57:17 PM (5 years ago)

Author:

david_quesada@apple.com

Message:

REGRESSION(r248533): Unable to use WTF::RefCounted when building in a debug configuration against a non-debug WebKit
​https://bugs.webkit.org/show_bug.cgi?id=201585
rdar://problem/55153369

Reviewed by Chris Dumez.

Export WTF::RefCountedBase::areThreadingChecksEnabledGlobally regardless of whether or not assertions
are enabled for the WTF being built. This allows WebKit-based projects to use RefCounted for their own
objects in a debug configuration without requiring a debug build of WebKit.

• wtf/RefCounted.cpp:
• wtf/RefCounted.h:

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/RefCounted.cpp (modified) (1 diff)
• wtf/RefCounted.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2019-09-07  David Quesada  <david_quesada@apple.com>
+
+        REGRESSION(r248533): Unable to use WTF::RefCounted when building in a debug configuration against a non-debug WebKit
+        https://bugs.webkit.org/show_bug.cgi?id=201585
+        rdar://problem/55153369
+
+        Reviewed by Chris Dumez.
+
+        Export WTF::RefCountedBase::areThreadingChecksEnabledGlobally regardless of whether or not assertions
+        are enabled for the WTF being built. This allows WebKit-based projects to use RefCounted for their own
+        objects in a debug configuration without requiring a debug build of WebKit.
+
+        * wtf/RefCounted.cpp:
+        * wtf/RefCounted.h:
+
 2019-09-07  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WTF/wtf/RefCounted.cpp

@@ -24 +24 @@
 namespace WTF {
 
-#if !ASSERT_DISABLED
 bool RefCountedBase::areThreadingChecksEnabledGlobally { false };
-#endif
 
 }

trunk/Source/WTF/wtf/RefCounted.h

@@ -165 +165 @@
     mutable bool m_isOwnedByMainThread;
     bool m_areThreadingChecksEnabled { true };
+#endif
     WTF_EXPORT_PRIVATE static bool areThreadingChecksEnabledGlobally;
-#endif
 #if CHECK_REF_COUNTED_LIFECYCLE
     mutable bool m_deletionHasBegun;