Changeset 249631 in webkit

Timestamp:

Sep 8, 2019 9:04:08 PM (5 years ago)

Author:

Wenson Hsieh

Message:

[macCatalyst] The last typed character in password fields shouldn't be echoed
​https://bugs.webkit.org/show_bug.cgi?id=201595
<rdar://problem/55166367>

Reviewed by Tim Horton.

Disable password echoing on macCatalyst, to better match behavior on macOS.

• Shared/WebPreferencesDefaultValues.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesDefaultValues.h (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-08  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        [macCatalyst] The last typed character in password fields shouldn't be echoed
+        https://bugs.webkit.org/show_bug.cgi?id=201595
+        <rdar://problem/55166367>
+
+        Reviewed by Tim Horton.
+
+        Disable password echoing on macCatalyst, to better match behavior on macOS.
+
+        * Shared/WebPreferencesDefaultValues.h:
+
 2019-09-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h

@@ -72 +72 @@
 #define DEFAULT_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY false
 #define DEFAULT_SHOULD_RESPECT_IMAGE_ORIENTATION true
-#define DEFAULT_PASSWORD_ECHO_ENABLED true
 #define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK false
 #define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_AFTER_FULLSCREEN true
@@ -93 +92 @@
 #define DEFAULT_JAVASCRIPT_CAN_OPEN_WINDOWS_AUTOMATICALLY true
 #define DEFAULT_SHOULD_RESPECT_IMAGE_ORIENTATION false
-#define DEFAULT_PASSWORD_ECHO_ENABLED false
 #define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK true
 #define DEFAULT_ALLOWS_INLINE_MEDIA_PLAYBACK_AFTER_FULLSCREEN false
@@ -108 +106 @@
 #endif
 
+#if PLATFORM(IOS_FAMILY) && !PLATFORM(MACCATALYST)
+#define DEFAULT_PASSWORD_ECHO_ENABLED true
+#else
+#define DEFAULT_PASSWORD_ECHO_ENABLED false
+#endif
+
 #if PLATFORM(COCOA)
 #define DEFAULT_ALLOW_MEDIA_CONTENT_TYPES_REQUIRING_HARDWARE_SUPPORT_AS_FALLBACK true