Changeset 24972 in webkit

Timestamp:

Aug 9, 2007 8:49:22 PM (17 years ago)

Author:

bdash

Message:

2007-08-09 Mitz Pettel <​mitz@webkit.org>

Reviewed by Adam Roben.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=14362 Opening a select list always highlights first element in list

• platform/win/PopupMenuWin.cpp: (WebCore::PopupWndProc): Track the mouse only inside the popup.

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/win/PopupMenuWin.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-09  Mitz Pettel  <mitz@webkit.org>
+
+        Reviewed by Adam Roben.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=14362
+          Opening a select list always highlights first element in list
+
+        * platform/win/PopupMenuWin.cpp:
+        (WebCore::PopupWndProc): Track the mouse only inside the popup.
+
 2007-08-09  Mitz Pettel  <mitz@webkit.org>
 

trunk/WebCore/platform/win/PopupMenuWin.cpp

@@ -712 +712 @@
                 ::SystemParametersInfo(SPI_GETHOTTRACKING, 0, &shouldHotTrack, 0);
 
-                if (shouldHotTrack || wParam & MK_LBUTTON)
+                RECT bounds;
+                GetClientRect(popup->popupHandle(), &bounds);
+                if ((shouldHotTrack || wParam & MK_LBUTTON) && ::PtInRect(&bounds, mousePoint))
                     popup->setFocusedIndex(popup->listIndexAtPoint(mousePoint), true);
 
                 // Release capture if the left button isn't down, and the mousePoint is outside the popup window.
                 // This way, the WebView will get future mouse events in the rest of the window.
-                RECT bounds;
-                GetClientRect(popup->popupHandle(), &bounds);
                 if (!(wParam & MK_LBUTTON) && !::PtInRect(&bounds, mousePoint)) {
                     ::ReleaseCapture();