Changeset 249732 in webkit

Timestamp:

Sep 10, 2019 1:37:01 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
​https://bugs.webkit.org/show_bug.cgi?id=201478

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2019-09-10
Reviewed by Simon Fraser.

-- Revert r249460 which changed drawGreenAndBlueCheckerboardInSoftware().
-- Remove the orientation bit from webgpu/resources/blue-checkered.png

so drawing it is not affected by r249364.

• webgpu/js/webgpu-functions.js:

(drawGreenAndBlueCheckerboardInSoftware):

• webgpu/resources/blue-checkered.png:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• webgpu/js/webgpu-functions.js (modified) (1 diff)
• webgpu/resources/blue-checkered.png (modified) (previous)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-09-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        REGRESSION (r249460): LayoutTests/webgpu/viewport-scissor-rect-triangle-strip.html is Failing
+        https://bugs.webkit.org/show_bug.cgi?id=201478
+
+        Reviewed by Simon Fraser.
+
+        -- Revert r249460 which changed drawGreenAndBlueCheckerboardInSoftware().
+        -- Remove the orientation bit from webgpu/resources/blue-checkered.png
+           so drawing it is not affected by r249364.
+
+        * webgpu/js/webgpu-functions.js:
+        (drawGreenAndBlueCheckerboardInSoftware):
+        * webgpu/resources/blue-checkered.png:
+
 2019-09-10  Nikolas Zimmermann  <zimmermann@kde.org>
 

trunk/LayoutTests/webgpu/js/webgpu-functions.js

@@ -39 +39 @@
     for (let x = 0; x < numColumns; ++x) {
         for (let y = 0; y < numRows; ++y) {
-            if ((x + y) % 2 == 1)
+            if ((x + y) % 2 == 0)
                 context.rect(
                     x * canvas.width / numColumns,