Changeset 249765 in webkit
- Timestamp:
- Sep 11, 2019 9:01:33 AM (5 years ago)
- Location:
- trunk
- Files:
-
- 4 deleted
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r249763 r249765 1 2019-09-11 Ryan Haddad <ryanhaddad@apple.com> 2 3 Unreviewed, rolling out r249758. 4 5 Breaks the watchOS build. 6 7 Reverted changeset: 8 9 "[WHLSL] Ensure structs/arrays with pointers as fields are 10 disallowed" 11 https://bugs.webkit.org/show_bug.cgi?id=201525 12 https://trac.webkit.org/changeset/249758 13 1 14 2019-09-11 Chris Dumez <cdumez@apple.com> 2 15 -
trunk/LayoutTests/webgpu/whlsl/array-spec-tests.html
r249758 r249765 30 30 } 31 31 `; 32 a wait checkFail(program);32 assert_equals(await callIntFunction(program, "foo", []), 76 + 39 + 83); 33 33 } 34 34 -
trunk/LayoutTests/webgpu/whlsl/js/test-harness.js
r249758 r249765 159 159 constructor () 160 160 { 161 this._loaded = false;162 161 } 163 162 … … 171 170 // FIXME: Add support for GPUAdapterRequestOptions and GPUDeviceDescriptor, 172 171 // and differentiate between descriptor validation errors and no WebGPU support. 173 } finally {174 this._loaded = true;175 172 } 176 173 } … … 186 183 async callTypedFunction(type, functions, name, args) 187 184 { 188 if (!this._loaded)189 throw new Error("GPU device not loaded.");190 191 185 if (this._device === undefined) 192 186 throw new WebGPUUnsupportedError(); … … 270 264 async checkCompileFail(source) 271 265 { 272 if (!this._loaded)273 throw new Error("GPU device not loaded.");274 275 266 if (this._device === undefined) 276 throw new WebGPUUnsupportedError();267 return; 277 268 278 269 let entryPointCode = ` … … 529 520 function runTests(obj) { 530 521 window.addEventListener("load", async () => { 531 await harness.requestDevice();532 522 try { 533 523 for (const name in obj) { -
trunk/LayoutTests/webgpu/whlsl/pointer-spec-tests.html
r249758 r249765 30 30 return result; 31 31 } 32 `; 33 a wait checkFail(program);32 `;; 33 assert_equals(await callIntFunction(program, "foo", []), 76 + 39 + 83); 34 34 } 35 35 -
trunk/LayoutTests/webgpu/whlsl/test-harness-test.html
r249758 r249765 187 187 }; 188 188 189 window.addEventListener("load", async() => {189 window.addEventListener("load", () => { 190 190 try { 191 await harness.requestDevice();192 191 for (const name in whlslTests) { 193 192 if (!name.startsWith("_")) -
trunk/Source/WebCore/ChangeLog
r249762 r249765 1 2019-09-11 Ryan Haddad <ryanhaddad@apple.com> 2 3 Unreviewed, rolling out r249758. 4 5 Breaks the watchOS build. 6 7 Reverted changeset: 8 9 "[WHLSL] Ensure structs/arrays with pointers as fields are 10 disallowed" 11 https://bugs.webkit.org/show_bug.cgi?id=201525 12 https://trac.webkit.org/changeset/249758 13 1 14 2019-09-11 Ali Juma <ajuma@chromium.org> 2 15 -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLChecker.cpp
r249758 r249765 937 937 if (is<AST::PointerType>(unnamedType)) { 938 938 auto& pointerType = downcast<AST::PointerType>(unnamedType); 939 // FIXME: https://bugs.webkit.org/show_bug.cgi?id=198163 Save the fact that we're not targetting the item; we're targetting the item's inner element. 939 940 assignConcreteType(makeArrayReferenceExpression, AST::ArrayReferenceType::create(makeArrayReferenceExpression.codeLocation(), pointerType.addressSpace(), pointerType.elementType())); 940 941 return; -
trunk/Source/WebCore/Modules/webgpu/WHLSL/WHLSLPrepare.cpp
r249758 r249765 32 32 #include "WHLSLCheckDuplicateFunctions.h" 33 33 #include "WHLSLCheckTextureReferences.h" 34 #include "WHLSLCheckReferenceTypes.h"35 34 #include "WHLSLChecker.h" 36 35 #include "WHLSLComputeDimensions.h" … … 233 232 RUN_PASS(checkLiteralTypes, program); 234 233 CHECK_PASS(checkTextureReferences, program); 235 CHECK_PASS(checkReferenceTypes, program);236 234 RUN_PASS(resolveProperties, program); 237 235 RUN_PASS(findHighZombies, program); -
trunk/Source/WebCore/Sources.txt
r249758 r249765 314 314 Modules/webgpu/WHLSL/WHLSLPruneUnreachableStandardLibraryFunctions.cpp 315 315 Modules/webgpu/WHLSL/WHLSLCheckTextureReferences.cpp 316 Modules/webgpu/WHLSL/WHLSLCheckReferenceTypes.cpp317 316 Modules/webgpu/WHLSL/WHLSLChecker.cpp 318 317 Modules/webgpu/WHLSL/WHLSLGatherEntryPointItems.cpp -
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
r249758 r249765 8332 8332 522E1A172297D6D400E5D36A /* WHLSLPreserveVariableLifetimes.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLPreserveVariableLifetimes.cpp; sourceTree = "<group>"; }; 8333 8333 522E1A192297D6D400E5D36A /* WHLSLPreserveVariableLifetimes.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLPreserveVariableLifetimes.h; sourceTree = "<group>"; }; 8334 524BD47E23277E15008F56C1 /* WHLSLCheckReferenceTypes.cpp */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.cpp; path = WHLSLCheckReferenceTypes.cpp; sourceTree = "<group>"; };8335 524BD48023277E16008F56C1 /* WHLSLCheckReferenceTypes.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = WHLSLCheckReferenceTypes.h; sourceTree = "<group>"; };8336 8334 526724F11CB2FDF60075974D /* TextTrackRepresentationCocoa.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = TextTrackRepresentationCocoa.mm; sourceTree = "<group>"; }; 8337 8335 526724F21CB2FDF60075974D /* TextTrackRepresentationCocoa.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = TextTrackRepresentationCocoa.h; sourceTree = "<group>"; }; … … 25582 25580 1C281C6D22B87B9800691C00 /* WHLSLCheckTextureReferences.cpp */, 25583 25581 1C281C6E22B87B9800691C00 /* WHLSLCheckTextureReferences.h */, 25584 524BD47E23277E15008F56C1 /* WHLSLCheckReferenceTypes.cpp */,25585 524BD48023277E16008F56C1 /* WHLSLCheckReferenceTypes.h */,25586 25582 522BAB9622E6A36200C54CE9 /* WHLSLCodeLocation.h */, 25587 25583 1C86CA4B22AA19FF001BF961 /* WHLSLComputeDimensions.cpp */,
Note: See TracChangeset
for help on using the changeset viewer.