Changeset 250243 in webkit

Timestamp:

Sep 23, 2019 11:06:18 AM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Improve the Uncaught Exception View file a bug link
​https://bugs.webkit.org/show_bug.cgi?id=201717

Reviewed by Devin Rousso.

Source/WebInspectorUI:

• UserInterface/Debug/UncaughtExceptionReporter.js:

Allow the link to be clicked. Use openInNewTab on click to also
bring the new tab to the foreground. Also update the content.

Source/WebKit:

• UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::bringInspectedPageToFront):

• UIProcess/WebInspectorProxy.h:
• UIProcess/WebInspectorProxy.messages.in:

Provide a way to bring the inspected page to the foreground.

• WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::openInNewTab):
Use it when opening a new tab beside the inspected page.

Location:

trunk/Source

Files:

• WebInspectorUI/ChangeLog (modified) (1 diff)
• WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js (modified) (3 diffs)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/WebInspectorProxy.cpp (modified) (1 diff)
• WebKit/UIProcess/WebInspectorProxy.h (modified) (1 diff)
• WebKit/UIProcess/WebInspectorProxy.messages.in (modified) (1 diff)
• WebKit/WebProcess/WebPage/WebInspectorUI.cpp (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-09-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve the Uncaught Exception View file a bug link
+        https://bugs.webkit.org/show_bug.cgi?id=201717
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Debug/UncaughtExceptionReporter.js:
+        Allow the link to be clicked. Use openInNewTab on click to also
+        bring the new tab to the foreground. Also update the content.
+
 2019-09-20  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Debug/UncaughtExceptionReporter.js

@@ -244 +244 @@
     let formattedErrorDetails = window.__uncaughtExceptions.map((entry) => formattedEntry(entry));
     let detailsForBugReport = formattedErrorDetails.map((line) => ` - ${line}`).join("\n");
-    topLevelItems.push("");
-    topLevelItems.push("Uncaught Exceptions:");
-    topLevelItems.push(detailsForBugReport);
-
-    let encodedBugDescription = encodeURIComponent(`-------
-${topLevelItems.join("\n")}
--------
-
-* STEPS TO REPRODUCE
+
+    let encodedBugDescription = encodeURIComponent(`Uncaught Exception in Web Inspector.
+
+Steps to Reproduce:
 1. What were you doing? Include setup or other preparations to reproduce the exception.
 2. Include explicit, accurate, and minimal steps taken. Do not include extraneous or irrelevant steps.
-
-* NOTES
-Document any additional information that might be useful in resolving the problem, such as screen shots or other included attachments.
+3. What did you expect to have happen? What actually happened?
+
+Uncaught Exceptions:
+-----------------------
+${detailsForBugReport}
+-----------------------
+
+Notes:
+${topLevelItems.join("\n")}
 `);
+
     let encodedBugTitle = encodeURIComponent(`Uncaught Exception: ${firstException.message}`);
     let encodedInspectedURL = encodeURIComponent(inspectedPageURL || "http://");
-    let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=${encodedInspectedURL}&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-1=X&flag_type-3=X&form_name=enter_bug&keywords=&op_sys=All&priority=P2&product=WebKit&rep_platform=All&short_desc=${encodedBugTitle}&version=WebKit%20Nightly%20Build`;
+    let prefilledBugReportLink = `https://bugs.webkit.org/enter_bug.cgi?alias=&assigned_to=webkit-unassigned%40lists.webkit.org&attach_text=&blocked=&bug_file_loc=${encodedInspectedURL}&bug_severity=Normal&bug_status=NEW&comment=${encodedBugDescription}&component=Web%20Inspector&contenttypeentry=&contenttypemethod=autodetect&contenttypeselection=text%2Fplain&data=&dependson=&description=&flag_type-1=X&flag_type-3=X&form_name=enter_bug&keywords=&op_sys=All&priority=P2&product=WebKit&rep_platform=All&short_desc=${encodedBugTitle}`;
     let detailsForHTML = formattedErrorDetails.map((line) => `<li>${insertWordBreakCharacters(line)}</li>`).join("\n");
 
@@ -279 +281 @@
         UI, or running an updated frontend with out-of-date WebKit build.</dt>
         <dt>I didn't do anything...?</dt>
-        <dd>If you don't think you caused this error to happen,
-        <a href="${prefilledBugReportLink}" target="_blank">click to file a pre-populated
-        bug with this information</a>. It is possible that someone else broke it by accident.</dd>
+        <dd><a href="${prefilledBugReportLink}" id="uncaught-exception-bug-report-link" class="bypass-event-blocking">Click to file a bug</a> as this is likely a Web Inspector bug.</dd>
         <dt>Oops, can I try again?</dt>
-        <dd><a href="javascript:InspectorFrontendHost.reopen()">Click to reload the Inspector</a>
+        <dd><a href="javascript:InspectorFrontendHost.reopen()" class="bypass-event-blocking">Click to reload the Inspector</a>
         again after making local changes.</dd>
         ${dismissOptionHTML}
@@ -296 +296 @@
     sheetElement.addEventListener("click", handleLinkClick, true);
     document.body.appendChild(sheetElement);
+
+    document.getElementById("uncaught-exception-bug-report-link").addEventListener("click", (event) => {
+        InspectorFrontendHost.openInNewTab(prefilledBugReportLink);
+        event.stopImmediatePropagation();
+        event.preventDefault();
+    });
 }
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-23  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Improve the Uncaught Exception View file a bug link
+        https://bugs.webkit.org/show_bug.cgi?id=201717
+
+        Reviewed by Devin Rousso.
+
+        * UIProcess/WebInspectorProxy.cpp:
+        (WebKit::WebInspectorProxy::bringInspectedPageToFront):
+        * UIProcess/WebInspectorProxy.h:
+        * UIProcess/WebInspectorProxy.messages.in:
+        Provide a way to bring the inspected page to the foreground.
+
+        * WebProcess/WebPage/WebInspectorUI.cpp:
+        (WebKit::WebInspectorUI::openInNewTab):
+        Use it when opening a new tab beside the inspected page.
+
 2019-09-23  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebKit/UIProcess/WebInspectorProxy.cpp

@@ -539 +539 @@
 }
 
+void WebInspectorProxy::bringInspectedPageToFront()
+{
+    platformBringInspectedPageToFront();
+}
+
 void WebInspectorProxy::attachAvailabilityChanged(bool available)
 {

trunk/Source/WebKit/UIProcess/WebInspectorProxy.h

@@ -223 +223 @@
     void didClose();
     void bringToFront();
+    void bringInspectedPageToFront();
     void attachAvailabilityChanged(bool);
     void inspectedURLChanged(const String&);

trunk/Source/WebKit/UIProcess/WebInspectorProxy.messages.in

@@ -30 +30 @@
     DidClose()
     BringToFront()
+    BringInspectedPageToFront()
     Reopen()
     ResetState()

trunk/Source/WebKit/WebProcess/WebPage/WebInspectorUI.cpp

@@ -264 +264 @@
 void WebInspectorUI::openInNewTab(const String& url)
 {
-    if (m_backendConnection)
+    if (m_backendConnection) {
         m_backendConnection->send(Messages::WebInspector::OpenInNewTab(url), 0);
+        WebProcess::singleton().parentProcessConnection()->send(Messages::WebInspectorProxy::BringInspectedPageToFront(), m_inspectedPageIdentifier);
+    }
 }