Changeset 250395 in webkit
- Timestamp:
- Sep 26, 2019 1:05:25 PM (5 years ago)
- Location:
- trunk
- Files:
-
- 7 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/imported/w3c/ChangeLog
r250385 r250395 1 2019-09-26 Truitt Savell <tsavell@apple.com> 2 3 Unreviewed, rolling out r250385. 4 5 Broke imported/w3c/web-platform-tests/svg/animations/syncbase- 6 remove-add-while-running.html on all platforms. Which was 7 caught by EWS 8 9 Reverted changeset: 10 11 "Non-callable "handleEvent" property is silently ignored" 12 https://bugs.webkit.org/show_bug.cgi?id=200066 13 https://trac.webkit.org/changeset/250385 14 1 15 2019-09-26 Alexey Shvayka <shvaikalesh@gmail.com> 2 16 -
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-error-event-exception-expected.txt
r250385 r250395 4 4 PASS Exception in error event listener on request 5 5 PASS Exception in error event listener ("handleEvent" lookup) on request 6 PASS Exception in error event listener (non-callable "handleEvent") on request 6 FAIL Exception in error event listener (non-callable "handleEvent") on request assert_equals: expected "AbortError" but got "ConstraintError" 7 7 PASS Exception in second error event listener on request 8 8 PASS Exception in first error event listener on request, transaction active in second -
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-success-event-exception-expected.txt
r250385 r250395 3 3 PASS Exception in success event listener on request 4 4 PASS Exception in success event listener ("handleEvent" lookup) on request 5 PASS Exception in success event listener (non-callable "handleEvent") on request 5 FAIL Exception in success event listener (non-callable "handleEvent") on request assert_unreached: transaction should abort Reached unreachable code 6 6 PASS Exception in second success event listener on request 7 7 PASS Exception in first success event listener, tx active in second -
trunk/LayoutTests/imported/w3c/web-platform-tests/IndexedDB/fire-upgradeneeded-event-exception-expected.txt
r250385 r250395 2 2 CONSOLE MESSAGE: line 37: Error 3 3 CONSOLE MESSAGE: line 44: Error 4 CONSOLE MESSAGE: TypeError: 'handleEvent' property of event listener should be callable5 4 CONSOLE MESSAGE: line 62: Error 6 5 CONSOLE MESSAGE: line 70: Error … … 9 8 PASS Exception in upgradeneeded listener 10 9 PASS Exception in upgradeneeded "handleEvent" lookup 11 PASS Exception in upgradeneeded due to non-callable "handleEvent" 10 FAIL Exception in upgradeneeded due to non-callable "handleEvent" assert_unreached: open should fail Reached unreachable code 12 11 PASS Exception in second upgradeneeded listener 13 12 PASS Exception in first upgradeneeded listener, tx active in second -
trunk/LayoutTests/imported/w3c/web-platform-tests/dom/events/EventListener-handleEvent-expected.txt
r250385 r250395 1 1 CONSOLE MESSAGE: line 46: [object Object] 2 CONSOLE MESSAGE: line 101: TypeError: 'handleEvent' property of event listener should be callable3 CONSOLE MESSAGE: line 122: TypeError: 'handleEvent' property of event listener should be callable4 2 5 3 PASS calls `handleEvent` method of `EventListener` … … 7 5 PASS performs `Get` every time event is dispatched 8 6 PASS doesn't call `handleEvent` method on callable `EventListener` 9 PASS throws if `handleEvent` is falsy and not callable 10 PASS throws if `handleEvent` is thruthy and not callable 7 FAIL throws if `handleEvent` is falsy and not callable assert_true: expected true got false 8 FAIL throws if `handleEvent` is thruthy and not callable assert_true: expected true got false 11 9 -
trunk/Source/WebCore/ChangeLog
r250393 r250395 1 2019-09-26 Truitt Savell <tsavell@apple.com> 2 3 Unreviewed, rolling out r250385. 4 5 Broke imported/w3c/web-platform-tests/svg/animations/syncbase- 6 remove-add-while-running.html on all platforms. Which was 7 caught by EWS 8 9 Reverted changeset: 10 11 "Non-callable "handleEvent" property is silently ignored" 12 https://bugs.webkit.org/show_bug.cgi?id=200066 13 https://trac.webkit.org/changeset/250385 14 1 15 2019-09-26 Kate Cheney <katherine_cheney@apple.com> 2 16 -
trunk/Source/WebCore/bindings/js/JSEventListener.cpp
r250385 r250395 149 149 } 150 150 callType = getCallData(vm, handleEventFunction, callData); 151 if (callType == CallType::None) { 152 event.target()->uncaughtExceptionInEventHandler(); 153 reportException(exec, createTypeError(exec, "'handleEvent' property of event listener should be callable"_s)); 154 return; 155 } 156 } 151 } 152 153 if (callType == CallType::None) 154 return; 157 155 158 156 Ref<JSEventListener> protectedThis(*this);
Note: See TracChangeset
for help on using the changeset viewer.