Changeset 250410 in webkit

Timestamp:

Sep 26, 2019 8:00:10 PM (5 years ago)

Author:

eric.carlson@apple.com

Message:

REGRESSION (iOS 13): Trying to record just audio using HTML Media Capture crashes Safari
​https://bugs.webkit.org/show_bug.cgi?id=202039
<rdar://problem/55566628>

Reviewed by Jer Noble.

Source/WebKit:

• UIProcess/ios/forms/WKFileUploadPanel.mm:

(-[WKFileUploadPanel _mediaTypesForPickerSourceType:]): UIImagePickerController doesn't
support audio-only recording, so show the video recorder for "audio/*".

LayoutTests:

• fast/forms/ios/file-upload-panel-capture-expected.txt: Added.
• fast/forms/ios/file-upload-panel-capture.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/ios/file-upload-panel-capture-expected.txt (added)
• LayoutTests/fast/forms/ios/file-upload-panel-capture.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-09-26  Eric Carlson  <eric.carlson@apple.com>
+
+        REGRESSION (iOS 13): Trying to record just audio using HTML Media Capture crashes Safari
+        https://bugs.webkit.org/show_bug.cgi?id=202039
+        <rdar://problem/55566628>
+
+        Reviewed by Jer Noble.
+
+        * fast/forms/ios/file-upload-panel-capture-expected.txt: Added.
+        * fast/forms/ios/file-upload-panel-capture.html: Added.
+
 2019-09-26  Russell Epstein  <repstein@apple.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2019-09-26  Eric Carlson  <eric.carlson@apple.com>
+
+        REGRESSION (iOS 13): Trying to record just audio using HTML Media Capture crashes Safari
+        https://bugs.webkit.org/show_bug.cgi?id=202039
+        <rdar://problem/55566628>
+
+        Reviewed by Jer Noble.
+
+        * UIProcess/ios/forms/WKFileUploadPanel.mm:
+        (-[WKFileUploadPanel _mediaTypesForPickerSourceType:]): UIImagePickerController doesn't 
+        support audio-only recording, so show the video recorder for "audio/*".
+
 2019-09-26  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/forms/WKFileUploadPanel.mm

@@ -344 +344 @@
             [mediaTypes addObject:(__bridge NSString *)kUTTypeMovie];
         else if ([mimeType caseInsensitiveCompare:@"audio/*"] == NSOrderedSame)
-            [mediaTypes addObject:(__bridge NSString *)kUTTypeAudio];
+            // UIImagePickerController doesn't allow audio-only recording, so show the video
+            // recorder for "audio/*".
+            [mediaTypes addObject:(__bridge NSString *)kUTTypeMovie];
         else {
             auto uti = WebCore::UTIFromMIMEType(mimeType);
@@ -372 +374 @@
             }
         }
-        return mediaTypes;
+
+        ASSERT(mediaTypes.count);
+        if (mediaTypes.count)
+            return mediaTypes;
     }