Changeset 250455 in webkit

Timestamp:

Sep 27, 2019 1:38:25 PM (5 years ago)

Author:

jiewen_tan@apple.com

Message:

Unreviewed, rolling out r250397.

caused failure on iOS 13

Reverted changeset:

"REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-
credential-create-success-u2f.https.html is failing"
​https://bugs.webkit.org/show_bug.cgi?id=201620
​https://trac.webkit.org/changeset/250397

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webauthn/fido/U2fResponseConverter.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-09-27  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, rolling out r250397.
+
+        caused failure on iOS 13
+
+        Reverted changeset:
+
+        "REGRESSION: [ Catalina WK2 ] http/wpt/webauthn/public-key-
+        credential-create-success-u2f.https.html is failing"
+        https://bugs.webkit.org/show_bug.cgi?id=201620
+        https://trac.webkit.org/changeset/250397
+
 2019-09-27  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/Modules/webauthn/fido/U2fResponseConverter.cpp

@@ -99 +99 @@
         return { };
 
-    Vector<uint8_t> aaguid(aaguidLength, 0);
+    Vector<uint8_t> aaguid(aaguidLength);
+    memset(aaguid.data(), 0, aaguidLength);
     return buildAttestedCredentialData(aaguid, credentialId, publicKey);
 }