Changeset 25101 in webkit

Timestamp:

Aug 15, 2007 2:29:27 PM (17 years ago)

Author:

justing

Message:

LayoutTests:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla

• editing/selection/14971-expected.checksum: Added.
• editing/selection/14971-expected.png: Added.
• editing/selection/14971-expected.txt: Added.
• editing/selection/14971.html: Added.

WebCore:

Reviewed by Darin.

​http://bugs.webkit.org/show_bug.cgi?id=14971
REGRESSION: cannot select reporter's e-mail in bugzilla

• page/EventHandler.cpp: (WebCore::EventHandler::canMouseDragExtendSelect): Allow drag-selecting inside a -webkit-user-select:ignore region.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection/14971-expected.checksum (added)
• LayoutTests/editing/selection/14971-expected.png (added)
• LayoutTests/editing/selection/14971-expected.txt (added)
• LayoutTests/editing/selection/14971.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/EventHandler.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-08-15  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Darin.
+        
+        http://bugs.webkit.org/show_bug.cgi?id=14971
+        REGRESSION: cannot select reporter's e-mail in bugzilla
+        
+        * editing/selection/14971-expected.checksum: Added.
+        * editing/selection/14971-expected.png: Added.
+        * editing/selection/14971-expected.txt: Added.
+        * editing/selection/14971.html: Added.
+
 2007-08-15  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-08-15  Justin Garcia  <justin.garcia@apple.com>
+
+        Reviewed by Darin.
+        
+        http://bugs.webkit.org/show_bug.cgi?id=14971
+        REGRESSION: cannot select reporter's e-mail in bugzilla
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::canMouseDragExtendSelect): Allow drag-selecting inside
+        a -webkit-user-select:ignore region.
+
 2007-08-15  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/page/EventHandler.cpp

@@ -1378 +1378 @@
 bool EventHandler::canMouseDragExtendSelect(Node* node)
 {
-    return canMouseDownStartSelect(node);
+    if (!node || !node->renderer())
+        return true;
+            
+    for (RenderObject* curr = node->renderer(); curr; curr = curr->parent())    
+        if (Node* node = curr->element())
+            return EventTargetNodeCast(node)->dispatchHTMLEvent(selectstartEvent, true, true);
+    
+    return true;
 }