Changeset 251328 in webkit

Timestamp:

Oct 19, 2019 4:50:32 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Flaky Test: fast/events/resize-subframe-in-rendering-update.html
​https://bugs.webkit.org/show_bug.cgi?id=203140
<rdar://problem/56415948>

Reviewed by Wenson Hsieh.

Removed the assertion in setTimeout to avoid flakiness. There isn't a way to deterministically order
callbacks of setTimeout and requestAnimationFrame for this test for now.

• fast/events/resize-subframe-in-rendering-update-expected.txt:
• fast/events/resize-subframe-in-rendering-update.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• fast/events/resize-subframe-in-rendering-update-expected.txt (modified) (1 diff)
• fast/events/resize-subframe-in-rendering-update.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2019-10-19  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Flaky Test: fast/events/resize-subframe-in-rendering-update.html
+        https://bugs.webkit.org/show_bug.cgi?id=203140
+        <rdar://problem/56415948>
+
+        Reviewed by Wenson Hsieh.
+
+        Removed the assertion in setTimeout to avoid flakiness. There isn't a way to deterministically order
+        callbacks of setTimeout and requestAnimationFrame for this test for now.
+
+        * fast/events/resize-subframe-in-rendering-update-expected.txt:
+        * fast/events/resize-subframe-in-rendering-update.html:
+
 2019-10-19  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update-expected.txt

@@ -8 +8 @@
 iframeAA.style.width = "200px"; updateLayout(iframeAA)
 PASS logs.length is 0
-After 0s setTimeout
-PASS logs.length is 0
 After requestAnimationFrame
 PASS logs.length is 3

trunk/LayoutTests/fast/events/resize-subframe-in-rendering-update.html

@@ -47 +47 @@
         });
     }, 0);
-    setTimeout(() => {
-        debug('After 0s setTimeout');
-        shouldBe('logs.length', '0');
-    }, 0);
 });