Changeset 251379 in webkit

Timestamp:

Oct 21, 2019, 1:43:00 PM (5 years ago)

Author:

Joseph Pecoraro

Message:

Web Inspector: Provide a flag for technology preview builds
​https://bugs.webkit.org/show_bug.cgi?id=203164
<rdar://problem/56202164>

Reviewed by Devin Rousso.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::isExperimentalBuild):

• inspector/InspectorFrontendHost.h:
• inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

• Localizations/en.lproj/localizedStrings.js:

• UserInterface/Test/Test.js:
• UserInterface/Base/Main.js:
• UserInterface/Base/Setting.js:

(WI.isTechnologyPreviewBuild):
(WI.arePreviewFeaturesEnabled):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
In non-TechnologyPreview builds, if there are Preview Features provide a
setting switch that can be used to match the TechnologyPreview features.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/inspector/InspectorFrontendHost.cpp (modified) (1 diff)
• WebCore/inspector/InspectorFrontendHost.h (modified) (1 diff)
• WebCore/inspector/InspectorFrontendHost.idl (modified) (1 diff)
• WebInspectorUI/ChangeLog (modified) (1 diff)
• WebInspectorUI/Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• WebInspectorUI/UserInterface/Base/Main.js (modified) (1 diff)
• WebInspectorUI/UserInterface/Base/Setting.js (modified) (2 diffs)
• WebInspectorUI/UserInterface/Test/Test.js (modified) (1 diff)
• WebInspectorUI/UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2019-10-21  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Provide a flag for technology preview builds
+        https://bugs.webkit.org/show_bug.cgi?id=203164
+        <rdar://problem/56202164>
+
+        Reviewed by Devin Rousso.
+
+        * inspector/InspectorFrontendHost.cpp:
+        (WebCore::InspectorFrontendHost::isExperimentalBuild):
+        * inspector/InspectorFrontendHost.h:
+        * inspector/InspectorFrontendHost.idl:
+
 2019-10-21  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp

@@ -447 +447 @@
 }
 
+bool InspectorFrontendHost::isExperimentalBuild()
+{
+#if ENABLE(EXPERIMENTAL_FEATURES)
+    return true;
+#else
+    return false;
+#endif
+}
+
 void InspectorFrontendHost::unbufferedLog(const String& message)
 {

trunk/Source/WebCore/inspector/InspectorFrontendHost.h

@@ -112 +112 @@
 
     bool isUnderTest();
+    bool isExperimentalBuild();
     void unbufferedLog(const String& message);
 

trunk/Source/WebCore/inspector/InspectorFrontendHost.idl

@@ -84 +84 @@
 
     boolean isUnderTest();
+    boolean isExperimentalBuild();
 
     void beep();

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2019-10-21  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: Provide a flag for technology preview builds
+        https://bugs.webkit.org/show_bug.cgi?id=203164
+        <rdar://problem/56202164>
+
+        Reviewed by Devin Rousso.
+
+        * Localizations/en.lproj/localizedStrings.js:
+
+        * UserInterface/Test/Test.js:
+        * UserInterface/Base/Main.js:
+        * UserInterface/Base/Setting.js:
+        (WI.isTechnologyPreviewBuild):
+        (WI.arePreviewFeaturesEnabled):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+        In non-TechnologyPreview builds, if there are Preview Features provide a
+        setting switch that can be used to match the TechnologyPreview features.
+
 2019-10-21  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -442 +442 @@
 localizedStrings["Enable Local Override"] = "Enable Local Override";
 localizedStrings["Enable New Tab Bar"] = "Enable New Tab Bar";
+localizedStrings["Enable Preview Features"] = "Enable Preview Features";
 localizedStrings["Enable Program"] = "Enable Program";
 localizedStrings["Enable Rule"] = "Enable Rule";
@@ -1064 +1065 @@
 localizedStrings["Specificity: No value for selected element"] = "Specificity: No value for selected element";
 localizedStrings["Spelling"] = "Spelling";
+localizedStrings["Staging:"] = "Staging:";
 localizedStrings["Stalled"] = "Stalled";
 localizedStrings["Start"] = "Start";

trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

@@ -3236 +3236 @@
 
 WI.isEngineeringBuild = false;
+WI.isExperimentalBuild = InspectorFrontendHost.isExperimentalBuild();
 
 // OpenResourceDialog delegate

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -187 +187 @@
 
     // Experimental
+    experimentalEnablePreviewFeatures: new WI.Setting("experimental-enable-preview-features", false),
     experimentalEnableLayersTab: new WI.Setting("experimental-enable-layers-tab", false),
     experimentalEnableNewTabBar: new WI.Setting("experimental-enable-new-tab-bar", false),
@@ -212 +213 @@
     debugLayoutDirection: new WI.Setting("debug-layout-direction-override", "system"),
 };
+
+WI.previewFeatures = [];
+
+WI.isTechnologyPreviewBuild = function()
+{
+    return WI.isExperimentalBuild && !WI.isEngineeringBuild;
+};
+
+WI.arePreviewFeaturesEnabled = function()
+{
+    if (WI.isExperimentalBuild)
+        return true;
+
+    if (WI.settings.experimentalEnablePreviewFeatures.value)
+        return true;
+
+    return false;
+};

trunk/Source/WebInspectorUI/UserInterface/Test/Test.js

@@ -184 +184 @@
 
 WI.isDebugUIEnabled = () => false;
+
+WI.isEngineeringBuild = false;
+WI.isExperimentalBuild = true;
 
 WI.unlocalizedString = (string) => string;

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -347 +347 @@
         let initialValues = new Map;
 
+        // WebKit may by default enable certain features in a Technology Preview that are not enabled in trunk.
+        // Provide a switch that will make non-preview builds behave like an experimental build, for those preview features.
+        let hasPreviewFeatures = WI.previewFeatures.length > 0;
+        if (hasPreviewFeatures && (WI.isTechnologyPreviewBuild() || WI.isEngineeringBuild)) {
+            experimentalSettingsView.addSetting(WI.UIString("Staging:"), WI.settings.experimentalEnablePreviewFeatures, WI.UIString("Enable Preview Features"));
+            experimentalSettingsView.addSeparator();
+        }
+
         if (InspectorBackend.hasDomain("LayerTree")) {
             experimentalSettingsView.addSetting(WI.UIString("Layers:"), WI.settings.experimentalEnableLayersTab, WI.UIString("Enable Layers Tab"));
@@ -382 +390 @@
         }
 
+        listenForChange(WI.settings.experimentalEnablePreviewFeatures);
         listenForChange(WI.settings.experimentalEnableLayersTab);
         listenForChange(WI.settings.experimentalEnableNewTabBar);